Sets the readonly state on read-only text fields on Windows.

Sets the readonly state on read-only text fields on Windows.

BUG=654768
R=dmazzoni@chromium.org
TESTED=manually with Jaws, browser tests

Committed: https://crrev.com/f4220a356ef824f05b65cadbcef910bb72736a44
Cr-Commit-Position: refs/heads/master@{#424860}

[nektarios, 2016-10-11 15:28:39]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 15:29:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 15:40:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 15:40:06]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dmazzoni, 2016-10-11 17:45:41]

https://codereview.chromium.org/2406233003/diff/40001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/2406233003/diff/40001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:5508: ia_state &=
~(STATE_SYSTEM_READONLY);
Won't this clear the readonly state for text fields
since they're focusable?

I think you need to fix this line of code, or
explain to me why not

https://codereview.chromium.org/2406233003/diff/40001/content/test/data/acces...
File content/test/data/accessibility/html/input-text-read-only-expected-win.txt
(right):

https://codereview.chromium.org/2406233003/diff/40001/content/test/data/acces...
content/test/data/accessibility/html/input-text-read-only-expected-win.txt:3:
++++ROLE_SYSTEM_TEXT name='Name' FOCUSABLE IA2_STATE_EDITABLE
IA2_STATE_SELECTABLE_TEXT IA2_STATE_SINGLE_LINE text-input-type:text
caret_offset=0 n_selections=0
Should this have READONLY?

https://codereview.chromium.org/2406233003/diff/40001/content/test/data/acces...
File content/test/data/accessibility/html/textarea-read-only-expected-win.txt
(right):

https://codereview.chromium.org/2406233003/diff/40001/content/test/data/acces...
content/test/data/accessibility/html/textarea-read-only-expected-win.txt:3:
++++ROLE_SYSTEM_TEXT FOCUSABLE IA2_STATE_EDITABLE IA2_STATE_MULTI_LINE
IA2_STATE_SELECTABLE_TEXT ia2_hypertext='The textarea tag defines a multi-line
text input control.
Same here

[nektarios, 2016-10-11 20:47:57]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 20:48:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 20:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 20:55:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[chromium-reviews, 2016-10-11 21:07:00]

All fixed and manually tested with Jaws and NVDA.

I found one issue though, I cannot cursor around in a read-only text 
field. Is this an accessibility bug or a limitation of Blink do you think?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2016-10-11 21:07:10]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 21:07:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-10-11 21:48:55]

I think that's working as intended for now

On Tue, Oct 11, 2016 at 2:07 PM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> All fixed and manually tested with Jaws and NVDA.
>
> I found one issue though, I cannot cursor around in a read-only text
> field. Is this an accessibility bug or a limitation of Blink do you think?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-10-11 21:50:02]

lgtm

[nektarios, 2016-10-11 22:15:41]

The CQ bit was unchecked by nektar@chromium.org

[nektarios, 2016-10-11 22:15:45]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:15:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:27:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2016-10-12 15:10:39]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-10-12 15:10:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2406233003/#ps100001
(title: "Fixed test expectations.")

[commit-bot: I haz the power, 2016-10-12 15:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:16:18]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[nektarios, 2016-10-12 15:27:08]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:36:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[nektarios, 2016-10-12 15:46:43]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:46:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 15:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 15:53:03]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[nektarios, 2016-10-12 21:15:17]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2016-10-12 21:16:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 21:25:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-12 21:29:04]

Description was changed from

==========
Sets the readonly state on read-only text fields on Windows.

BUG=654768
R=dmazzoni@chromium.org
TESTED=manually with Jaws, browser tests
==========

to

==========
Sets the readonly state on read-only text fields on Windows.

BUG=654768
R=dmazzoni@chromium.org
TESTED=manually with Jaws, browser tests

Committed: https://crrev.com/f4220a356ef824f05b65cadbcef910bb72736a44
Cr-Commit-Position: refs/heads/master@{#424860}
==========

[commit-bot: I haz the power, 2016-10-12 21:29:05]

Patchset 6 (id:??) landed as
https://crrev.com/f4220a356ef824f05b65cadbcef910bb72736a44
Cr-Commit-Position: refs/heads/master@{#424860}