third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 2406203004: Compute registered properties after resolving high priority properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 2406203004: Compute registered properties after resolving high priority properties (Closed)

Patch Set: font size cycle test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

index 46ee042dd0bfc72e003a56f247efa90f815447fe..38d3d9a3f46aa93e31397c0b94a87a4da09b230e 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -954,8 +954,6 @@ void StyleBuilderFunctions::applyValueCSSPropertyVariable(

const CSSValue* parsedValue =

declaration.value()->parseForSyntax(registration->syntax());

if (parsedValue) {

- parsedValue = &StyleBuilderConverter::convertRegisteredPropertyValue(

- state, *parsedValue);

DCHECK(parsedValue);

if (isInheritedProperty)

state.style()->setResolvedInheritedVariable(name, declaration.value(),