chromecast/browser/cast_http_user_agent_settings.cc - Issue 2406203002: Use BCP47 compliant format for locale representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/cast_http_user_agent_settings.cc

Issue 2406203002: Use BCP47 compliant format for locale representation (Closed)

Patch Set: Rebased, using .equals(), create compat for forLanguageTag, more tests added Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/cast_http_user_agent_settings.cc

diff --git a/chromecast/browser/cast_http_user_agent_settings.cc b/chromecast/browser/cast_http_user_agent_settings.cc

index fcce6bafc5320b4f33082ce231ca5c6756eb2e52..1161c00ed0f3fa8e64b00bb9217cb567f291af28 100644

--- a/chromecast/browser/cast_http_user_agent_settings.cc

+++ b/chromecast/browser/cast_http_user_agent_settings.cc

@@ -33,7 +33,7 @@ std::string CastHttpUserAgentSettings::GetAcceptLanguage() const {

std::string new_locale(

#if defined(OS_ANDROID)

// TODO(byungchul): Use transient locale set when new app starts.

- base::android::GetDefaultLocale()

+ base::android::GetDefaultLocaleString()

#else

base::i18n::GetConfiguredLocale()

#endif