Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Unified Diff: base/android/junit/src/org/chromium/base/LocaleUtilsTest.java

Issue 2406203002: Use BCP47 compliant format for locale representation (Closed)
Patch Set: Add mapping from Chromium to Android for forLanguageTag Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/junit/src/org/chromium/base/LocaleUtilsTest.java
diff --git a/base/android/junit/src/org/chromium/base/LocaleUtilsTest.java b/base/android/junit/src/org/chromium/base/LocaleUtilsTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..25b35a9a2d24b11b61f0f8b4104ac26a50463dff
--- /dev/null
+++ b/base/android/junit/src/org/chromium/base/LocaleUtilsTest.java
@@ -0,0 +1,127 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.base;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.robolectric.annotation.Config;
+
+import org.chromium.testing.local.LocalRobolectricTestRunner;
+
+import java.util.Locale;
+
+/** Unit tests for the LocaleUtils class. */
+@RunWith(LocalRobolectricTestRunner.class)
+@Config(manifest = Config.NONE)
+public class LocaleUtilsTest {
+ // TODO(yirui): update tests for LocaleList once SDK Roll is completed.
+ @Test
+ public void testToLanguageTag() {
+ Locale locale = new Locale("en", "US");
+ String localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("en-US", localeString);
+
+ locale = new Locale("jp");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("jp", localeString);
+
+ locale = new Locale("mas");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("mas", localeString);
+
+ locale = new Locale("es", "005");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("es-005", localeString);
+
+ locale = new Locale("iw");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("he", localeString);
+
+ locale = new Locale("ji");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("yi", localeString);
+
+ locale = new Locale("in", "ID");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("id-ID", localeString);
+
+ locale = new Locale("tl", "PH");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("fil-PH", localeString);
+
+ locale = new Locale("no", "NO", "NY");
+ localeString = LocaleUtils.toLanguageTag(locale);
+ Assert.assertEquals("nn-NO", localeString);
+ }
+
+ @Test
+ public void testForLanguageTag() {
+ String languageTag = "";
+ Locale locale = new Locale("");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "en";
+ locale = new Locale("en");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "mas";
+ locale = new Locale("mas");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "en-GB";
+ locale = new Locale("en", "GB");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "es-419";
+ locale = new Locale("es", "419");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ // Tests if updated Chromium language code and deprecated language code
+ // are pointing to the same Locale Object.
+ languageTag = "he";
+ locale = new Locale("iw");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "iw";
+ locale = new Locale("he");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "ji";
+ locale = new Locale("yi");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "yi";
+ locale = new Locale("ji");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "in";
+ locale = new Locale("id");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "id";
+ locale = new Locale("in");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ // Tests for Tagalog/Filipino if updated Chromium language code and
+ // language code are pointing to the same Locale Object.
+ languageTag = "tl";
+ locale = new Locale("tl");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "fil";
+ locale = new Locale("tl");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ // Test with invalid inputs.
+ languageTag = "notValidLanguage";
+ locale = new Locale("");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+
+ languageTag = "en-notValidCountry";
+ locale = new Locale("en");
+ Assert.assertEquals(locale, LocaleUtils.forLanguageTag(languageTag));
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698