ui/base/l10n/l10n_util.cc - Issue 2406203002: Use BCP47 compliant format for locale representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/l10n/l10n_util.cc

Issue 2406203002: Use BCP47 compliant format for locale representation (Closed)

Patch Set: add more explanations about why Locale.getLanguage/toLanguageTag is not used Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/l10n/l10n_util.cc

diff --git a/ui/base/l10n/l10n_util.cc b/ui/base/l10n/l10n_util.cc

index 0f40495d4fed6b69c757a17cd52e5ff8f540dd0f..47001b4ae69b7886336058d14ec5066257d28273 100644

--- a/ui/base/l10n/l10n_util.cc

+++ b/ui/base/l10n/l10n_util.cc

@@ -459,7 +459,7 @@ std::string GetApplicationLocaleInternal(const std::string& pref_locale) {

#elif defined(OS_ANDROID)

// On Android, query java.util.Locale for the default locale.

- candidates.push_back(base::android::GetDefaultLocale());

+ candidates.push_back(base::android::GetDefaultLocaleString());

#elif defined(USE_GLIB) && !defined(OS_CHROMEOS)