base/android/locale_utils.h - Issue 2406203002: Use BCP47 compliant format for locale representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/locale_utils.h

Issue 2406203002: Use BCP47 compliant format for locale representation (Closed)

Patch Set: add more explanations about why Locale.getLanguage/toLanguageTag is not used Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/locale_utils.h

diff --git a/base/android/locale_utils.h b/base/android/locale_utils.h

index b0f3c07ff1795b376eecd8040c53bb9dad6b132b..be68890dfea40cd5841908e0a5393adbb44402c0 100644

--- a/base/android/locale_utils.h

+++ b/base/android/locale_utils.h

@@ -16,8 +16,8 @@ namespace android {

BASE_EXPORT std::string GetDefaultCountryCode();

-// Return the current default locale of the device.

-BASE_EXPORT std::string GetDefaultLocale();

+// Return the current default locale of the device as string.

+BASE_EXPORT std::string GetDefaultLocaleString();

} // namespace android

} // namespace base