base/BUILD.gn - Issue 2406203002: Use BCP47 compliant format for locale representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 2406203002: Use BCP47 compliant format for locale representation (Closed)

Patch Set: add more explanations about why Locale.getLanguage/toLanguageTag is not used Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index 1c47b51f922ea12e2ee5c48af724e507518f0fbb..aef9ce602792bd43789e163cb0dbaccf20fccc0b 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -2348,6 +2348,7 @@ if (is_android) {

"android/javatests/src/org/chromium/base/ApiCompatibilityUtilsTest.java",

"android/javatests/src/org/chromium/base/CommandLineInitUtilTest.java",

"android/javatests/src/org/chromium/base/CommandLineTest.java",

+ "android/javatests/src/org/chromium/base/LocaleUtilsTest.java",

"android/javatests/src/org/chromium/base/ObserverListTest.java",

"android/javatests/src/org/chromium/base/metrics/RecordHistogramTest.java",

]