android_webview/browser/aw_browser_main_parts.cc - Issue 2406203002: Use BCP47 compliant format for locale representation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_browser_main_parts.cc

Issue 2406203002: Use BCP47 compliant format for locale representation (Closed)

Patch Set: add more explanations about why Locale.getLanguage/toLanguageTag is not used Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_browser_main_parts.cc

diff --git a/android_webview/browser/aw_browser_main_parts.cc b/android_webview/browser/aw_browser_main_parts.cc

index d30b07d66f5c564768a98f0d52257e4abbd4c54a..bfb81d87d1e15995b2ed65d59d6d45ef15a12bc3 100644

--- a/android_webview/browser/aw_browser_main_parts.cc

+++ b/android_webview/browser/aw_browser_main_parts.cc

@@ -96,8 +96,7 @@ void AwBrowserMainParts::PreEarlyInitialization() {

int AwBrowserMainParts::PreCreateThreads() {

ui::SetLocalePaksStoredInApk(true);

std::string locale = ui::ResourceBundle::InitSharedInstanceWithLocale(

- base::android::GetDefaultLocale(),

- NULL,

+ base::android::GetDefaultLocaleString(), NULL,

ui::ResourceBundle::LOAD_COMMON_RESOURCES);

if (locale.empty()) {

LOG(WARNING) << "Failed to load locale .pak from the apk. "