Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2406183002: Revert of Revert "Mojoify FetchEvent of Service Worker." (Closed)

Created:
4 years, 2 months ago by horo
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, abarth-chromium, Aaron Boodman, kinuko+serviceworker, yzshen+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, darin (slow to review), blink-worker-reviews_chromium.org, garykac
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Mojoify FetchEvent of Service Worker." (patchset #1 id:1 of https://codereview.chromium.org/2399903003/ ) Reason for revert: The crash reported in https://crbug.com/653403 was fixed by https://crrev.com/2396293002/. BUG=653403, 649558, 629701 Original issue's description: > Revert "Mojoify FetchEvent of Service Worker." > > This reverts commit bdc8e1e4477f7dcd911528720a50d639be6d39b5. > This is a top crasher that's blocking release. > > BUG=653403 > TBR=horo@chromium.org > > Committed: https://crrev.com/9a64a996a29e3fcdc07f8d7927fdebeb66faa44a > Cr-Commit-Position: refs/heads/master@{#423663} TBR=dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=653403 Committed: https://crrev.com/011e3a5aa9acefa9794e74bc1facc50c2eeedea9 Cr-Commit-Position: refs/heads/master@{#424407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -83 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.h View 7 chunks +17 lines, -6 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 10 chunks +58 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 3 chunks +20 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 12 chunks +24 lines, -33 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A content/common/service_worker/fetch_event_dispatcher.mojom View 1 chunk +17 lines, -0 lines 0 comments Download
A content/common/service_worker/fetch_event_dispatcher.typemap View 1 chunk +20 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 2 chunks +0 lines, -8 lines 0 comments Download
A content/common/service_worker/service_worker_status_code_traits.h View 1 chunk +25 lines, -0 lines 0 comments Download
A content/common/service_worker/service_worker_status_code_traits.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M content/common/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 4 chunks +8 lines, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 9 chunks +58 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
horo
Created Revert of Revert "Mojoify FetchEvent of Service Worker."
4 years, 2 months ago (2016-10-11 08:20:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406183002/1
4 years, 2 months ago (2016-10-11 08:22:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/313617)
4 years, 2 months ago (2016-10-11 10:40:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406183002/1
4 years, 2 months ago (2016-10-11 10:51:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 11:59:31 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 12:01:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/011e3a5aa9acefa9794e74bc1facc50c2eeedea9
Cr-Commit-Position: refs/heads/master@{#424407}

Powered by Google App Engine
This is Rietveld 408576698