[Sync] Services can now always assume processor exists.

components/sync/model/fake_model_type_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SYNC_MODEL_FAKE_MODEL_TYPE_SERVICE_H_
 #define COMPONENTS_SYNC_MODEL_FAKE_MODEL_TYPE_SERVICE_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 94 matching lines @@
   SyncError MergeSyncData(
       std::unique_ptr<MetadataChangeList> metadata_change_list,
       EntityDataMap entity_data_map) override;
   SyncError ApplySyncChanges(
       std::unique_ptr<MetadataChangeList> metadata_change_list,
       EntityChangeList entity_changes) override;
   void GetData(StorageKeyList storage_keys, DataCallback callback) override;
   void GetAllData(DataCallback callback) override;
   std::string GetClientTag(const EntityData& entity_data) override;
   std::string GetStorageKey(const EntityData& entity_data) override;
-  void OnChangeProcessorSet() override;
   ConflictResolution ResolveConflict(
       const EntityData& local_data,
       const EntityData& remote_data) const override;
 
   // Store a resolution for the next call to ResolveConflict. Note that if this
   // is a USE_NEW resolution, the data will only exist for one resolve call.
   void SetConflictResolution(ConflictResolution resolution);
 
   // Sets the error that the next fallible call to the service will generate.
   void SetServiceError(SyncError::ErrorType error_type);
 
-  const Store& db() const { return db_; }
+  Store* db() { return db_.get(); }

[maxbogue, 2016/10/12 23:40:35]

Out of curiosity, why change the signature instead of returning *db_?

[skym, 2016/10/13 19:21:38]

Because I wanted it to be modifiable, and my understanding is that we don't like
non-const refs. But it looks like I actually don't need it to be modifiable
anymore, reverting.

 
  protected:
   // Used to verify conditions upon destruction.
   virtual void CheckPostConditions();
 
   // Contains all of the data and metadata state.
-  Store db_;
+  std::unique_ptr<Store> db_;
 
  private:
   // Applies |change_list| to the metadata store.
   void ApplyMetadataChangeList(std::unique_ptr<MetadataChangeList> change_list);
 
   // The conflict resolution to use for calls to ResolveConflict.
   std::unique_ptr<ConflictResolution> conflict_resolution_;
 
   // The error to produce on the next service call.
   SyncError service_error_;
 };
 
 }  // namespace syncer
 
 #endif  // COMPONENTS_SYNC_MODEL_FAKE_MODEL_TYPE_SERVICE_H_