[Sync] Services can now always assume processor exists.

chrome/browser/sync/test/integration/two_client_uss_sync_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/sync/chrome_sync_client.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
@@ skipping 38 matching lines @@
 // A FakeModelTypeService that supports observing ApplySyncChanges.
 class TestModelTypeService : public FakeModelTypeService {
  public:
   class Observer {
    public:
     virtual void OnApplySyncChanges() = 0;
   };
 
   TestModelTypeService()
       : FakeModelTypeService(
-            base::Bind(&SharedModelTypeProcessor::CreateAsChangeProcessor)) {}
+            base::Bind(&SharedModelTypeProcessor::CreateAsChangeProcessor)) {
+    change_processor()->OnMetadataLoaded(syncer::SyncError(),
+                                         db()->CreateMetadataBatch());
+  }
 
   syncer::SyncError ApplySyncChanges(
       std::unique_ptr<syncer::MetadataChangeList> metadata_changes,
       syncer::EntityChangeList entity_changes) override {
     syncer::SyncError error = FakeModelTypeService::ApplySyncChanges(
         std::move(metadata_changes), entity_changes);
     NotifyObservers();
     return error;
   }
 
-  void OnChangeProcessorSet() override {
-    change_processor()->OnMetadataLoaded(syncer::SyncError(),
-                                         db().CreateMetadataBatch());
-  }
-
   void AddObserver(Observer* observer) { observers_.insert(observer); }
   void RemoveObserver(Observer* observer) { observers_.erase(observer); }
 
  private:
   void NotifyObservers() {
     for (Observer* observer : observers_) {
       observer->OnApplySyncChanges();
     }
   }
 
@@ skipping 21 matching lines @@
 
 // Wait for data for a key to have a certain value.
 class DataChecker : public KeyChecker {
  public:
   DataChecker(TestModelTypeService* service,
               const std::string& key,
               const std::string& value)
       : KeyChecker(service, key), value_(value) {}
 
   bool IsExitConditionSatisfied() override {
-    const auto& db = service_->db();
+    const auto& db = *service_->db();
     return db.HasData(key_) && db.GetValue(key_) == value_;
   }
 
   std::string GetDebugMessage() const override {
     return "Waiting for data for key '" + key_ + "' to be '" + value_ + "'.";
   }
 
  private:
   const std::string value_;
 };
 
 // Wait for data for a key to be absent.
 class DataAbsentChecker : public KeyChecker {
  public:
   DataAbsentChecker(TestModelTypeService* service, const std::string& key)
       : KeyChecker(service, key) {}
 
   bool IsExitConditionSatisfied() override {
-    return !service_->db().HasData(key_);
+    return !service_->db()->HasData(key_);
   }
 
   std::string GetDebugMessage() const override {
     return "Waiting for data for key '" + key_ + "' to be absent.";
   }
 };
 
 // Wait for metadata for a key to be present.
 class MetadataPresentChecker : public KeyChecker {
  public:
   MetadataPresentChecker(TestModelTypeService* service, const std::string& key)
       : KeyChecker(service, key) {}
 
   bool IsExitConditionSatisfied() override {
-    return service_->db().HasMetadata(key_);
+    return service_->db()->HasMetadata(key_);
   }
 
   std::string GetDebugMessage() const override {
     return "Waiting for metadata for key '" + key_ + "' to be present.";
   }
 };
 
 // Wait for metadata for a key to be absent.
 class MetadataAbsentChecker : public KeyChecker {
  public:
   MetadataAbsentChecker(TestModelTypeService* service, const std::string& key)
       : KeyChecker(service, key) {}
 
   bool IsExitConditionSatisfied() override {
-    return !service_->db().HasMetadata(key_);
+    return !service_->db()->HasMetadata(key_);
   }
 
   std::string GetDebugMessage() const override {
     return "Waiting for metadata for key '" + key_ + "' to be absent.";
   }
 };
 
 // Wait for PREFERENCES to no longer be running.
 class PrefsNotRunningChecker : public SingleClientStatusChangeChecker {
  public:
@@ skipping 75 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(TwoClientUssSyncTest, DisableEnable) {
   ASSERT_TRUE(SetupSync());
   TestModelTypeService* model1 = GetModelTypeService(0);
   TestModelTypeService* model2 = GetModelTypeService(1);
 
   // Add an entity to test with.
   model1->WriteItem(kKey1, kValue1);
   ASSERT_TRUE(DataChecker(model2, kKey1, kValue1).Wait());
-  ASSERT_EQ(1U, model1->db().data_count());
-  ASSERT_EQ(1U, model1->db().metadata_count());
-  ASSERT_EQ(1U, model2->db().data_count());
-  ASSERT_EQ(1U, model2->db().metadata_count());
+  ASSERT_EQ(1U, model1->db()->data_count());
+  ASSERT_EQ(1U, model1->db()->metadata_count());
+  ASSERT_EQ(1U, model2->db()->data_count());
+  ASSERT_EQ(1U, model2->db()->metadata_count());
 
   // Disable PREFERENCES.
   syncer::ModelTypeSet types = syncer::UserSelectableTypes();
   types.Remove(syncer::PREFERENCES);
   GetSyncService(0)->OnUserChoseDatatypes(false, types);
 
   // Wait for it to take effect and remove the metadata.
   ASSERT_TRUE(MetadataAbsentChecker(model1, kKey1).Wait());
-  ASSERT_EQ(1U, model1->db().data_count());
-  ASSERT_EQ(0U, model1->db().metadata_count());
+  ASSERT_EQ(1U, model1->db()->data_count());
+  ASSERT_EQ(0U, model1->db()->metadata_count());
   // Model 2 should not be affected.
-  ASSERT_EQ(1U, model2->db().data_count());
-  ASSERT_EQ(1U, model2->db().metadata_count());
+  ASSERT_EQ(1U, model2->db()->data_count());
+  ASSERT_EQ(1U, model2->db()->metadata_count());
 
   // Re-enable PREFERENCES.
   GetSyncService(0)->OnUserChoseDatatypes(true, syncer::UserSelectableTypes());
 
   // Wait for metadata to be re-added.
   ASSERT_TRUE(MetadataPresentChecker(model1, kKey1).Wait());
-  ASSERT_EQ(1U, model1->db().data_count());
-  ASSERT_EQ(1U, model1->db().metadata_count());
-  ASSERT_EQ(1U, model2->db().data_count());
-  ASSERT_EQ(1U, model2->db().metadata_count());
+  ASSERT_EQ(1U, model1->db()->data_count());
+  ASSERT_EQ(1U, model1->db()->metadata_count());
+  ASSERT_EQ(1U, model2->db()->data_count());
+  ASSERT_EQ(1U, model2->db()->metadata_count());
 }
 
 IN_PROC_BROWSER_TEST_F(TwoClientUssSyncTest, ConflictResolution) {
   ASSERT_TRUE(SetupSync());
   TestModelTypeService* model1 = GetModelTypeService(0);
   TestModelTypeService* model2 = GetModelTypeService(1);
   model1->SetConflictResolution(ConflictResolution::UseNew(
       FakeModelTypeService::GenerateEntityData(kKey1, kValue3)));
   model2->SetConflictResolution(ConflictResolution::UseNew(
       FakeModelTypeService::GenerateEntityData(kKey1, kValue3)));
@@ skipping 17 matching lines @@
   model1->WriteItem(kKey1, kValue1);
   ASSERT_TRUE(DataChecker(model2, kKey1, kValue1).Wait());
 
   // Set an error in model 2 to trigger in the next GetUpdates.
   model2->SetServiceError(syncer::SyncError::DATATYPE_ERROR);
   // Write an item on model 1 to trigger a GetUpdates in model 2.
   model1->WriteItem(kKey1, kValue2);
 
   // The type should stop syncing but keep tracking metadata.
   ASSERT_TRUE(PrefsNotRunningChecker(GetSyncService(1)).Wait());
-  ASSERT_EQ(1U, model2->db().metadata_count());
+  ASSERT_EQ(1U, model2->db()->metadata_count());
   model2->WriteItem(kKey2, kValue2);
-  ASSERT_EQ(2U, model2->db().metadata_count());
+  ASSERT_EQ(2U, model2->db()->metadata_count());
 }