third_party/WebKit/Source/core/dom/Document.cpp - Issue 2406163004: Simplify the usage of PositionWithAffinity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2406163004: Simplify the usage of PositionWithAffinity (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 144707c24ad8cbf0b2f71577088c1a93e9fa319c..1d02cf51a8f803f3045df673fe1cb1b8534986fd 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -1220,7 +1220,7 @@ Range* Document::caretRangeFromPoint(int x, int y) {

HitTestResult result = hitTestInDocument(this, x, y);

PositionWithAffinity positionWithAffinity = result.position();

- if (positionWithAffinity.position().isNull())

+ if (positionWithAffinity.isNull())

return nullptr;

Position rangeCompliantPosition =

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »