[wasm] Implement decoding of i32v values

[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=v8:4203
Committed: https://crrev.com/dde9c073bfd1dd1a1c09819387dcbdc8cab9f4f9
Cr-Commit-Position: refs/heads/master@{#40157}

[Clemens Hammacher, 2016-10-11 07:06:41]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 07:06:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 07:12:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 07:12:19]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/15812)

[Clemens Hammacher, 2016-10-11 07:29:32]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 07:29:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-10-11 07:34:23]

lgtm with nits

https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h
File src/wasm/decoder.h (right):

https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h#newcode182
src/wasm/decoder.h:182: int32_t consume_i32v(const char* name = nullptr) {
Can you add tests for this function?

https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h#newcode353
src/wasm/decoder.h:353: template <typename IntType, bool is_signed>
Can you measure a performance difference between is_signed being a template or
is_signed being a normal parameter?

[commit-bot: I haz the power, 2016-10-11 07:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 07:53:37]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-10-11 08:14:15]

On 2016/10/11 07:34:23, ahaas wrote:
> lgtm with nits
> 
> https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h
> File src/wasm/decoder.h (right):
> 
>
https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h#newcode182
> src/wasm/decoder.h:182: int32_t consume_i32v(const char* name = nullptr) {
> Can you add tests for this function?
> 

+1

>
https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h#newcode353
> src/wasm/decoder.h:353: template <typename IntType, bool is_signed>
> Can you measure a performance difference between is_signed being a template or
> is_signed being a normal parameter?

lgtm

[Clemens Hammacher, 2016-10-11 08:16:43]

On 2016/10/11 08:14:15, titzer wrote:
> On 2016/10/11 07:34:23, ahaas wrote:
> > lgtm with nits
> > 
> > https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h
> > File src/wasm/decoder.h (right):
> > 
> >
>
https://codereview.chromium.org/2406163002/diff/1/src/wasm/decoder.h#newcode182
> > src/wasm/decoder.h:182: int32_t consume_i32v(const char* name = nullptr) {
> > Can you add tests for this function?
> > 
> 
> +1

The test is there since patch set 2.

[Clemens Hammacher, 2016-10-11 08:28:02]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 08:28:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-10-11 08:33:09]

Description was changed from

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
==========

to

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=chromium:4203
==========

[Clemens Hammacher, 2016-10-11 08:33:28]

Description was changed from

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=chromium:4203
==========

to

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

[commit-bot: I haz the power, 2016-10-11 08:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 08:59:40]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-10-11 09:00:28]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-10-11 09:00:28]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2406163002/#ps40001
(title: "Remove redundant check")

[commit-bot: I haz the power, 2016-10-11 09:00:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 09:03:28]

Description was changed from

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

to

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

[commit-bot: I haz the power, 2016-10-11 09:03:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-11 09:03:44]

Description was changed from

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=v8:4203
==========

to

==========
[wasm] Implement decoding of i32v values

I use it in a follow-up commit to delta-encode asm.js source positions.

This commit also removes the redundant consume_bytes function.

R=ahaas@chromium.org, titzer@chromium.org
BUG=v8:4203

Committed: https://crrev.com/dde9c073bfd1dd1a1c09819387dcbdc8cab9f4f9
Cr-Commit-Position: refs/heads/master@{#40157}
==========

[commit-bot: I haz the power, 2016-10-11 09:03:46]

Patchset 3 (id:??) landed as
https://crrev.com/dde9c073bfd1dd1a1c09819387dcbdc8cab9f4f9
Cr-Commit-Position: refs/heads/master@{#40157}