Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2406133002: pubsub: pending fix (Closed)

Created:
4 years, 2 months ago by Ryan Tseng
Modified:
4 years, 2 months ago
Reviewers:
dnj, martiniss, hinoka
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

pubsub: pending fix 1. Rename misspelled "pendingBuildStatues" to "pendingBuildStates" 2. Yieldind a deferred list returns a list of tupes with success, we only want to return the data. BUG=654623 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fb0560def63fcd666d8ef9ece802d88622d200fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M scripts/master/pubsub_json_status_push.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
hinoka
ptal
4 years, 2 months ago (2016-10-11 04:16:05 UTC) #4
dnj
lgtm
4 years, 2 months ago (2016-10-11 13:50:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406133002/1
4 years, 2 months ago (2016-10-11 21:38:59 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 21:43:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/fb0560def63fcd666d8e...

Powered by Google App Engine
This is Rietveld 408576698