Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: extensions/common/extension.h

Issue 240613004: Add UMA logging of extension creation flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index c7b8458193dd8c0e999250bbe55c3a5180b7b7c0..5be02942828fdd3414366b02a46206e97dfac1be 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -117,6 +117,8 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
virtual ~ManifestData() {}
};
+ // Do not change the order of entries or remove entries in this list
+ // as this is used in UMA_HISTOGRAM_ENUMERATIONs about extensions.
enum InitFromValueFlags {
NO_FLAGS = 0,
@@ -169,6 +171,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// be placed in a special OEM folder in the App Launcher. Note: OEM apps are
// also installed by Default (i.e. WAS_INSTALLED_BY_DEFAULT is also true).
WAS_INSTALLED_BY_OEM = 1 << 10,
+ LAST_INIT_FROM_VALUE_FLAGS = WAS_INSTALLED_BY_OEM,
};
static scoped_refptr<Extension> Create(const base::FilePath& path,

Powered by Google App Engine
This is Rietveld 408576698