Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: extensions/common/extension.h

Issue 240613004: Add UMA logging of extension creation flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add kInitFromValueFlagBits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index 3354fa625c2a170096a871cc86cb70c285e6b5fd..8a7e78e59129220e3a0d9d8c453b6917820a1d91 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -117,6 +117,8 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
virtual ~ManifestData() {}
};
+ // Do not change the order of entries or remove entries in this list
+ // as this is used in UMA_HISTOGRAM_ENUMERATIONs about extensions.
enum InitFromValueFlags {
NO_FLAGS = 0,
@@ -169,8 +171,13 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// be placed in a special OEM folder in the App Launcher. Note: OEM apps are
// also installed by Default (i.e. WAS_INSTALLED_BY_DEFAULT is also true).
WAS_INSTALLED_BY_OEM = 1 << 10,
+
+ // When adding new flags, make sure to update kInitFromValueFlagBits.
};
+ // This is the highest bit index of the flags defined above.
+ static const int kInitFromValueFlagBits;
+
static scoped_refptr<Extension> Create(const base::FilePath& path,
Manifest::Location location,
const base::DictionaryValue& value,
« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698