Add UMA logging of extension creation flags.

chrome/browser/extensions/installed_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/installed_loader.h"
 
 #include "base/files/file_path.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 96 matching lines @@
 }
 
 BackgroundPageType GetBackgroundPageType(const Extension* extension) {
   if (!BackgroundInfo::HasBackgroundPage(extension))
     return NO_BACKGROUND_PAGE;
   if (BackgroundInfo::HasPersistentBackgroundPage(extension))
     return BACKGROUND_PAGE_PERSISTENT;
   return EVENT_PAGE;
 }
 
+// Records the creation flags of an extension grouped by
+// Extension::InitFromValueFlags.
+void RecordCreationFlags(const Extension* extension) {
+  int highest_flag_bit = 0;
+  for (int i = 1; i < Extension::LAST_INIT_FROM_VALUE_FLAGS; i <<= 1)

[benwells, 2014/04/22 06:41:44]

Nit: add a comment explaining what you're doing here / why you're doing this
loop.

[calamity, 2014/04/22 06:56:28]

Done.

+    ++highest_flag_bit;
+
+  int flag = 1;
+  for (int i = 1; i <= highest_flag_bit; ++i) {
+    if (extension->creation_flags() & flag) {
+      UMA_HISTOGRAM_ENUMERATION(
+          "Extensions.LoadCreationFlags", i, highest_flag_bit + 1);
+    }
+    flag <<= 1;
+  }
+}
+
 }  // namespace
 
 InstalledLoader::InstalledLoader(ExtensionService* extension_service)
     : extension_service_(extension_service),
       extension_registry_(ExtensionRegistry::Get(extension_service->profile())),
       extension_prefs_(ExtensionPrefs::Get(extension_service->profile())) {}
 
 InstalledLoader::~InstalledLoader() {
 }
 
@@ skipping 269 matching lines @@
     ExtensionActionManager* extension_action_manager =
         ExtensionActionManager::Get(extension_service_->profile());
     if (extension_action_manager->GetPageAction(*ex->get()))
       ++page_action_count;
     if (extension_action_manager->GetBrowserAction(*ex->get()))
       ++browser_action_count;
 
     if (extensions::ManagedModeInfo::IsContentPack(ex->get()))
       ++content_pack_count;
 
+    RecordCreationFlags(*ex);
+
     extension_service_->RecordPermissionMessagesHistogram(
         ex->get(), "Extensions.Permissions_Load");
   }
 
   const ExtensionSet& disabled_extensions =
       extension_registry_->disabled_extensions();
   for (ex = disabled_extensions.begin(); ex != disabled_extensions.end();
        ++ex) {
     if (extension_prefs_->DidExtensionEscalatePermissions((*ex)->id())) {
       ++disabled_for_permissions_count;
@@ skipping 61 matching lines @@
 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {
   int flags = extension_prefs_->GetCreationFlags(info->extension_id);
   if (!Manifest::IsUnpackedLocation(info->extension_location))
     flags |= Extension::REQUIRE_KEY;
   if (extension_prefs_->AllowFileAccess(info->extension_id))
     flags |= Extension::ALLOW_FILE_ACCESS;
   return flags;
 }
 
 }  // namespace extensions