Issue 2406123002: Remove I411 support, update doc and switch to side by side test

Issue 2406123002: Remove I411 support, update doc and switch to side by side test (Closed)

Created:
4 years, 2 months ago by fbarchard1

Modified:
4 years, 2 months ago

Reviewers:
kjellander_chromium

CC:
magjed_chromium

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

More Reviews

Description

Remove I411 support. YUV 411 is very uncommon format. Remove support. Update documentation to reflect that 411 is deprecated. Simplify tests for YUV to only test with the new side by side YUV but keep old 3 plane test around with a macro for now. BUG=libyuv:645 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/d363ea6527bf84b9498279c378e90de1dd8e3fcd

Patch Set 1 #

Patch Set 2 : bump version, disable a few lint warnings #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -913 lines)			Patch
M	README.chromium	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	docs/formats.md	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	include/libyuv/convert.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	include/libyuv/convert_argb.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	include/libyuv/convert_from.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	include/libyuv/convert_from_argb.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	include/libyuv/mjpeg_decoder.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	include/libyuv/row.h	View		12 chunks	+0 lines, -54 lines	0 comments	Download
M	include/libyuv/version.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/video_common.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	source/convert.cc	View		1 chunk	+0 lines, -21 lines	0 comments	Download
M	source/convert_argb.cc	View		1 chunk	+0 lines, -69 lines	0 comments	Download
M	source/convert_from.cc	View	1	3 chunks	+1 line, -37 lines	0 comments	Download
M	source/convert_from_argb.cc	View	1	2 chunks	+1 line, -74 lines	0 comments	Download
M	source/convert_jpeg.cc	View		6 chunks	+2 lines, -56 lines	0 comments	Download
M	source/convert_to_argb.cc	View	1	2 chunks	+1 line, -15 lines	0 comments	Download
M	source/convert_to_i420.cc	View	1	2 chunks	+1 line, -17 lines	0 comments	Download
M	source/row_any.cc	View		5 chunks	+0 lines, -23 lines	0 comments	Download
M	source/row_common.cc	View		2 chunks	+0 lines, -77 lines	0 comments	Download
M	source/row_gcc.cc	View		4 chunks	+0 lines, -103 lines	0 comments	Download
M	source/row_neon.cc	View		3 chunks	+0 lines, -104 lines	0 comments	Download
M	source/row_neon64.cc	View		3 chunks	+0 lines, -91 lines	0 comments	Download
M	source/row_win.cc	View		4 chunks	+0 lines, -113 lines	0 comments	Download
M	unit_test/convert_test.cc	View	1	8 chunks	+7 lines, -12 lines	0 comments	Download
M	unit_test/video_common_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fbarchard1

git cl lint has no new errors but lots of old ones: Done processing include/libyuv/video_common.h ...

4 years, 2 months ago (2016-10-11 03:14:53 UTC) #3

git cl lint has no new errors but lots of old ones:
Done processing include/libyuv/video_common.h
source/convert.cc:976:  Namespace should be terminated with "// namespace
libyuv"  [readability/namespace] [5]
Done processing source/convert_argb.cc
source/convert_from.cc:881:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
Done processing source/convert_from.cc
source/convert_from_argb.cc:842:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
Done processing source/convert_from_argb.cc
source/convert_jpeg.cc:39:  Using C-style cast.  Use
reinterpret_cast<I420Buffers*>(...) instead  [readability/casting] [4]
source/convert_jpeg.cc:57:  Using C-style cast.  Use
reinterpret_cast<I420Buffers*>(...) instead  [readability/casting] [4]
source/convert_jpeg.cc:75:  Using C-style cast.  Use
reinterpret_cast<I420Buffers*>(...) instead  [readability/casting] [4]
source/convert_jpeg.cc:93:  Using C-style cast.  Use
reinterpret_cast<I420Buffers*>(...) instead  [readability/casting] [4]
source/convert_jpeg.cc:208:  Using C-style cast.  Use
reinterpret_cast<ARGBBuffers*>(...) instead  [readability/casting] [4]
source/convert_jpeg.cc:222:  Using C-style cast.  Use
reinterpret_cast<ARGBBuffers*>(...) instead  [readability/casting] [4]
source/convert_jpeg.cc:236:  Using C-style cast.  Use
reinterpret_cast<ARGBBuffers*>(...) instead  [readability/casting] [4]
source/convert_jpeg.cc:250:  Using C-style cast.  Use
reinterpret_cast<ARGBBuffers*>(...) instead  [readability/casting] [4]
Done processing source/convert_jpeg.cc
source/convert_to_argb.cc:70:  Using C-style cast.  Use
reinterpret_cast<uint8*>(...) instead  [readability/casting] [4]
Done processing source/convert_to_argb.cc
source/convert_to_i420.cc:73:  Using C-style cast.  Use
reinterpret_cast<uint8*>(...) instead  [readability/casting] [4]
Done processing source/convert_to_i420.cc
Done processing source/row_any.cc
source/row_common.cc:36:  Using C-style cast.  Use static_cast<uint32>(...)
instead  [readability/casting] [4]
source/row_common.cc:54:  Using C-style cast.  Use static_cast<uint32>(...)
instead  [readability/casting] [4]
source/row_common.cc:63:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:212:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:246:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:261:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:272:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:288:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:299:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:1232:  Using C-style cast.  Use static_cast<uint32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1233:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1234:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1235:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1244:  Using C-style cast.  Use static_cast<uint32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1245:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1246:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1247:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:1404:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:1416:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:1443:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:1455:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:1482:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:1494:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:1567:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:1578:  Using C-style cast.  Use
reinterpret_cast<uint16*>(...) instead  [readability/casting] [4]
source/row_common.cc:1700:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:1756:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:2062:  Using C-style cast.  Use static_cast<int>(...)
instead  [readability/casting] [4]
source/row_common.cc:2063:  Using C-style cast.  Use static_cast<int>(...)
instead  [readability/casting] [4]
source/row_common.cc:2064:  Using C-style cast.  Use
reinterpret_cast<uint32*>(...) instead  [readability/casting] [4]
source/row_common.cc:2225:  Using C-style cast.  Use static_cast<float>(...)
instead  [readability/casting] [4]
source/row_common.cc:2226:  Using C-style cast.  Use static_cast<float>(...)
instead  [readability/casting] [4]
source/row_common.cc:2227:  Using C-style cast.  Use static_cast<float>(...)
instead  [readability/casting] [4]
source/row_common.cc:2228:  Using C-style cast.  Use static_cast<float>(...)
instead  [readability/casting] [4]
source/row_common.cc:2250:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:2251:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:2252:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:2253:  Using C-style cast.  Use static_cast<int32>(...)
instead  [readability/casting] [4]
source/row_common.cc:2274:  Using C-style cast.  Use static_cast<uint16>(...)
instead  [readability/casting] [4]
source/row_common.cc:2274:  Using C-style cast.  Use
reinterpret_cast<uint32_t*>(...) instead  [readability/casting] [4]
Done processing source/row_neon64.cc
source/row_win.cc:32:  Using C-style cast.  Use reinterpret_cast<uint32*>(...)
instead  [readability/casting] [4]
source/row_win.cc:33:  Using C-style cast.  Use reinterpret_cast<uint32*>(...)
instead  [readability/casting] [4]
source/row_win.cc:37:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:43:  Using C-style cast.  Use reinterpret_cast<uint32*>(...)
instead  [readability/casting] [4]
source/row_win.cc:44:  Using C-style cast.  Use reinterpret_cast<uint32*>(...)
instead  [readability/casting] [4]
source/row_win.cc:48:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:51:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:58:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:59:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:60:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:61:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:62:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:63:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:64:  Using C-style cast.  Use reinterpret_cast<__m128i*>(...)
instead  [readability/casting] [4]
source/row_win.cc:82:  Using C-style cast.  Use reinterpret_cast<__m128i *>(...)
instead  [readability/casting] [4]
source/row_win.cc:83:  Using C-style cast.  Use reinterpret_cast<__m128i *>(...)
instead  [readability/casting] [4]
source/row_win.cc:96:  Using C-style cast.  Use reinterpret_cast<uint8*>(...)
instead  [readability/casting] [4]
source/row_win.cc:115:  Using C-style cast.  Use reinterpret_cast<uint8*>(...)
instead  [readability/casting] [4]
source/row_win.cc:1943:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:1944:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:1957:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:1958:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2059:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2060:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2364:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2365:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2368:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2380:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2392:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2395:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2401:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2404:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2411:  Extra space before [  [whitespace/braces] [5]
source/row_win.cc:2414:  Extra space before [  [whitespace/braces] [5]
Total errors found: 87

kjellander_chromium

lgtm, +magjed FYI We really should fix that MIPS bot, or is it depending on ...

4 years, 2 months ago (2016-10-11 03:52:49 UTC) #4

fbarchard1

On 2016/10/11 03:52:49, kjellander_chromium wrote: > lgtm, +magjed FYI > > We really should fix ...

4 years, 2 months ago (2016-10-11 17:15:39 UTC) #5

fbarchard1

4 years, 2 months ago (2016-10-11 18:14:20 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d363ea6527bf84b9498279c378e90de1dd8e3fcd (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages