Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2406093002: Fix monochrome not booting issue (Closed)

Created:
4 years, 2 months ago by sgurun-gerrit only
Modified:
4 years, 2 months ago
Reviewers:
slan, Peter Wen, Torne, agrieve, xunjieli, Ted C, nyquist, estevenson, michaelbai
CC:
chromium-reviews, nyquist+watch-blimp_chromium.org, android-webview-reviews_chromium.org, kmarshall+watch-blimp_chromium.org, agrieve+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, lcwu+watch_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, jbudorick+watch_chromium.org, mlamouri+watch-content_chromium.org, halliwell+watch_chromium.org, Peter Beverloo, lizeb+watch-custom-tabs_chromium.org, alokp+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, mikecase+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix monochrome not booting issue Revert these two CLs to have monochrome working again on ToT. Revert "Move PathUtils to use ContextUtils." commit 7200e9f34aa2e9006d8ea5540035de744b13d27d. Revert "Reland of Move language pak files to assets." commit 67101cd0338a409d80689b9c9c875c95ccde7957. BUG=653771, 644377, 529604 TBR==agrieve@chromium.org,tedchoc@chromium.org,slan@chromium.org,xunjieli@chromium.org,torne@chromium.org,nyquist@chromium.org,wnwen@chromium.org, michaelbai@chomium.org, estevenson@chromium.org Committed: https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b Cr-Commit-Position: refs/heads/master@{#424345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -222 lines) Patch
M android_webview/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 3 chunks +3 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java View 3 chunks +5 lines, -3 lines 0 comments Download
M android_webview/system_webview_apk_tmpl.gni View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/test/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 2 chunks +12 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 2 chunks +1 line, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/LocaleUtils.java View 3 chunks +9 lines, -17 lines 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 3 chunks +15 lines, -12 lines 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 9 chunks +42 lines, -32 lines 0 comments Download
M base/android/java/templates/BuildConfig.template View 1 chunk +0 lines, -15 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java View 2 chunks +5 lines, -5 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java View 2 chunks +2 lines, -1 line 0 comments Download
A build/android/gyp/locale_pak_resources.py View 1 chunk +126 lines, -0 lines 0 comments Download
M build/android/gyp/write_build_config.py View 6 chunks +22 lines, -12 lines 0 comments Download
M build/android/resource_sizes.py View 2 chunks +12 lines, -21 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +7 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 6 chunks +73 lines, -9 lines 0 comments Download
M chrome/android/BUILD.gn View 7 chunks +35 lines, -22 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 5 chunks +13 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 2 chunks +5 lines, -8 lines 0 comments Download
M components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java View 9 chunks +5 lines, -12 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java View 2 chunks +1 line, -3 lines 0 comments Download
M components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java View 2 chunks +4 lines, -2 lines 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 chunk +5 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ContentApplication.java View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +8 lines, -5 lines 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 chunk +7 lines, -4 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 2 chunks +7 lines, -6 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ResourceBundle.java View 2 chunks +65 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406093002/1
4 years, 2 months ago (2016-10-11 01:35:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 02:37:09 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5cb262f964b4a158be02b5497462e2e8d170a59b Cr-Commit-Position: refs/heads/master@{#424345}
4 years, 2 months ago (2016-10-11 02:38:52 UTC) #8
agrieve
4 years, 2 months ago (2016-10-11 20:07:36 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2404253003/ by agrieve@chromium.org.

The reason for reverting is: Will update when fixed..

Powered by Google App Engine
This is Rietveld 408576698