Crazylinker: remove the code to load component build library

base/android/java/src/org/chromium/base/library_loader/Linker.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.base.library_loader;
 
 import android.os.Build;
 import android.os.Bundle;
 import android.os.Parcel;
 import android.os.ParcelFileDescriptor;
@@ skipping 501 matching lines @@
     public boolean isChromiumLinkerLibrary(String library) {
         return library.equals(LINKER_JNI_LIBRARY) || library.equals(LINKER_JNI_LIBRARY + ".cr");
     }
 
     /**
      * Load the Linker JNI library. Throws UnsatisfiedLinkError on error.
      * In a component build, the suffix ".cr" is added to each library name, so
      * if the initial load fails we retry with a suffix.
      */
     protected static void loadLinkerJniLibrary() {
+        // Fallback on component build doesn't work for the most devices which
+        // have chrome preinstalled because libchromium_android_linker.so could
+        // already be in system lib path, and you will never get exception,
+        // instead, load wrong library.
         String libName = "lib" + LINKER_JNI_LIBRARY + ".so";
         if (DEBUG) {
             Log.i(TAG, "Loading " + libName);
         }
         try {
             System.loadLibrary(LINKER_JNI_LIBRARY);
         } catch (UnsatisfiedLinkError e) {
             Log.w(TAG, "Couldn't load " + libName + ", trying " + libName + ".cr");
             System.loadLibrary(LINKER_JNI_LIBRARY + ".cr");

[michaelbai, 2016/10/11 18:26:37]

If you don't think crazy linker will support component build, I could just
remove this.

         }
     }
 
     /**
      * Obtain a random base load address at which to place loaded libraries.
      *
      * @return new base load address
      */
     protected long getRandomBaseLoadAddress() {
         // nativeGetRandomBaseLoadAddress() returns an address at which it has previously
@@ skipping 283 matching lines @@
      * Return a random address that should be free to be mapped with the given size.
      * Maps an area large enough for the largest library we might attempt to load,
      * and if successful then unmaps it and returns the address of the area allocated
      * by the system (with ASLR). The idea is that this area should remain free of
      * other mappings until we map our library into it.
      *
      * @return address to pass to future mmap, or 0 on error.
      */
     private static native long nativeGetRandomBaseLoadAddress();
 }