PlzNavigate: Fix the failing ContinueWhereILeftOffTest.PostWithPassword test.

content/browser/frame_host/navigation_entry_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_entry_impl.h"
 
 #include <stddef.h>
 
 #include <queue>
 #include <utility>
@@ skipping 671 matching lines @@
   // subframe navigation entries.
   if (IsBrowserSideNavigationEnabled())
     method = frame_entry.method();
   else
     method = (post_body.get() || GetHasPostData()) ? "POST" : "GET";
 
   return CommonNavigationParams(
       dest_url, dest_referrer, GetTransitionType(), navigation_type,
       !IsViewSourceMode(), should_replace_entry(), ui_timestamp, report_type,
       GetBaseURLForDataURL(), GetHistoryURLForDataURL(), lofi_state,
-      navigation_start, method, post_body ? post_body : post_data_);
+      navigation_start, method, false, post_body ? post_body : post_data_);

[clamy, 2016/10/13 12:56:17]

Does the stripping of password data from the post_body happens on the renderer
side before we send the PageState to the renderer or does it happen when
serializing it to disk? If the later, it would be possible when doing a back
forward navigation that we lose the information that the post data containing a
password if we don't store it alongside the post body in the
FrameNavigationEntry.

Another place where we could lose this information is when the navigation goes
through the OpenURL path (and transfer navigations in the current architecture).
All in all, I wonder if it would not be better to add a boolean on the post body
explicitly rather than try to store it along and possibly miss edge cases.

[ananta, 2016/10/13 20:16:43]

Thanks for pointing out the issue with OpenURL. As far as the stripping of the
password data from PageState is concerned, that happens in the browser during
shutdown. That works correctly here.

I added the flag to the ResourceRequestBodyImpl class which works correctly for
OpenURL and the BeginNavigation code path. I updated the relevant places which
need to ensure that the flag gets marshaled across. PTAL and let me know if we
missed something.

 }
 
 StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()
     const {
   return StartNavigationParams(extra_headers(),
                                transferred_global_request_id().child_id,
                                transferred_global_request_id().request_id);
 }
 
 RequestNavigationParams NavigationEntryImpl::ConstructRequestNavigationParams(
@@ skipping 235 matching lines @@
       return node;
 
     // Enqueue any children and keep looking.
     for (auto* child : node->children)
       work_queue.push(child);
   }
   return nullptr;
 }
 
 }  // namespace content