PlzNavigate: Fix the failing ContinueWhereILeftOffTest.PostWithPassword test.

content/common/page_state_serialization.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/page_state_serialization.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <limits>
@@ skipping 747 matching lines @@
   g_device_scale_factor_for_testing = 0.0;
   return rv;
 }
 
 scoped_refptr<ResourceRequestBodyImpl> DecodeResourceRequestBody(
     const char* data,
     size_t size) {
   scoped_refptr<ResourceRequestBodyImpl> result = new ResourceRequestBodyImpl();
   SerializeObject obj(data, static_cast<int>(size));
   ReadResourceRequestBody(&obj, result);
+  // Please see the EncodeResourceRequestBody() function below for information
+  // this is being explicitl deserialized.

[Łukasz Anforowicz, 2016/10/15 00:02:27]

nit:explicitly
nit:s/this/that/

[ananta, 2016/10/15 00:23:31]

Done.

+  result->set_contains_sensitive_info(ReadBoolean(&obj));
   return obj.parse_error ? nullptr : result;
 }
 
 std::string EncodeResourceRequestBody(
     const ResourceRequestBodyImpl& resource_request_body) {
   SerializeObject obj;
   obj.version = kCurrentVersion;
   WriteResourceRequestBody(resource_request_body, &obj);
+  // We are serializing the contains_sensitive_info() field explicitly to avoid
+  // changing the WriteResourceRequestBody function which would require a
+  // PageState version update.

[Łukasz Anforowicz, 2016/10/15 00:02:27]

Maybe we could tweak the comment to say why EncodeResourceRequestBody is
different from WriteResourceRequestBody: EncodeResourceRequestBody covers
additional data (e.g. |contains_sensitive_info|) because it needs to marshal all
in-memory data between native code and Java (and WriteResourceRequestBody only
covers data that needs to be saved to disk).

[ananta, 2016/10/15 00:23:31]

Done.

+  WriteBoolean(resource_request_body.contains_sensitive_info(), &obj);
   return obj.GetAsString();
 }
 
 #endif
 
 }  // namespace content