Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2406043002: MD Settings: Prevent <settings-prefs> from being initialized in guest mode. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, stevenjb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Prevent <settings-prefs> from being initialized in guest mode. BUG=654588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (7 generated)
dpapad
4 years, 2 months ago (2016-10-21 21:26:19 UTC) #7
michaelpg
not lgtm Guest mode on Chrome OS needs settings-prefs, although chrome.settingsPrivate isn't working properly: crbug.com/648496 ...
4 years, 2 months ago (2016-10-22 01:51:55 UTC) #8
michaelpg
3 years, 10 months ago (2017-02-09 21:51:29 UTC) #9
Suggest closing this while we fix the remaining guest mode issues.

Powered by Google App Engine
This is Rietveld 408576698