Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 240603004: Fix handlification bug in test (Closed)

Created:
6 years, 8 months ago by rossberg
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix use of rand #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M test/cctest/test-types.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rossberg
6 years, 8 months ago (2014-04-17 09:23:16 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/240603004/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/240603004/diff/1/test/cctest/test-types.cc#newcode283 test/cctest/test-types.cc:283: TypeHandle type = Type::Function(result, receiver, rand() % 3, region_); ...
6 years, 8 months ago (2014-04-17 09:25:33 UTC) #2
rossberg
https://codereview.chromium.org/240603004/diff/1/test/cctest/test-types.cc File test/cctest/test-types.cc (right): https://codereview.chromium.org/240603004/diff/1/test/cctest/test-types.cc#newcode283 test/cctest/test-types.cc:283: TypeHandle type = Type::Function(result, receiver, rand() % 3, region_); ...
6 years, 8 months ago (2014-04-17 09:27:46 UTC) #3
Benedikt Meurer
LGTM
6 years, 8 months ago (2014-04-17 09:29:05 UTC) #4
rossberg
6 years, 8 months ago (2014-04-17 09:30:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r20835 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698