chrome/renderer/pepper/pepper_extensions_common_host.cc - Issue 240603003: Remove ChromeV8Extension & most of ChromeV8Context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/pepper/pepper_extensions_common_host.cc

Issue 240603003: Remove ChromeV8Extension & most of ChromeV8Context (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/pepper/pepper_extensions_common_host.cc

diff --git a/chrome/renderer/pepper/pepper_extensions_common_host.cc b/chrome/renderer/pepper/pepper_extensions_common_host.cc

index 1bda041d646e35f6f338e4d160638bb9b4d94da4..ed38547d6e901f86c9330f460f36c5fb0f5e64ca 100644

--- a/chrome/renderer/pepper/pepper_extensions_common_host.cc

+++ b/chrome/renderer/pepper/pepper_extensions_common_host.cc

@@ -63,9 +63,11 @@ PepperExtensionsCommonHost* PepperExtensionsCommonHost::Create(

if (!frame)

return NULL;

v8::HandleScope scope(v8::Isolate::GetCurrent());

+ // TODO(rockot): Remove this downcast. See http://crbug.com/362616.

extensions::ChromeV8Context* context =

- dispatcher->v8_context_set().GetByV8Context(

- frame->mainWorldScriptContext());

+ static_cast<extensions::ChromeV8Context*>(

+ dispatcher->script_context_set().GetByV8Context(

+ frame->mainWorldScriptContext()));

if (!context)

return NULL;