Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: chrome/renderer/extensions/v8_schema_registry.cc

Issue 240603003: Remove ChromeV8Extension & most of ChromeV8Context (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/v8_schema_registry.cc
diff --git a/chrome/renderer/extensions/v8_schema_registry.cc b/chrome/renderer/extensions/v8_schema_registry.cc
deleted file mode 100644
index 7c1b910f81616c1feba184b34c6d7cddd22024ef..0000000000000000000000000000000000000000
--- a/chrome/renderer/extensions/v8_schema_registry.cc
+++ /dev/null
@@ -1,114 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/renderer/extensions/v8_schema_registry.h"
-
-#include "base/logging.h"
-#include "base/values.h"
-#include "chrome/renderer/extensions/chrome_v8_context.h"
-#include "content/public/renderer/v8_value_converter.h"
-#include "extensions/common/extension_api.h"
-#include "extensions/renderer/object_backed_native_handler.h"
-
-using content::V8ValueConverter;
-
-namespace extensions {
-
-namespace {
-
-class SchemaRegistryNativeHandler : public ObjectBackedNativeHandler {
- public:
- SchemaRegistryNativeHandler(V8SchemaRegistry* registry,
- scoped_ptr<ChromeV8Context> context)
- : ObjectBackedNativeHandler(context.get()),
- context_(context.Pass()),
- registry_(registry) {
- RouteFunction("GetSchema",
- base::Bind(&SchemaRegistryNativeHandler::GetSchema,
- base::Unretained(this)));
- }
-
- private:
- void GetSchema(const v8::FunctionCallbackInfo<v8::Value>& args) {
- args.GetReturnValue().Set(
- registry_->GetSchema(*v8::String::Utf8Value(args[0])));
- }
-
- scoped_ptr<ChromeV8Context> context_;
- V8SchemaRegistry* registry_;
-};
-
-} // namespace
-
-V8SchemaRegistry::V8SchemaRegistry() {}
-
-V8SchemaRegistry::~V8SchemaRegistry() {}
-
-scoped_ptr<NativeHandler> V8SchemaRegistry::AsNativeHandler() {
- scoped_ptr<ChromeV8Context> context(new ChromeV8Context(
- GetOrCreateContext(v8::Isolate::GetCurrent()),
- NULL, // no frame
- NULL, // no extension
- Feature::UNSPECIFIED_CONTEXT));
- return scoped_ptr<NativeHandler>(
- new SchemaRegistryNativeHandler(this, context.Pass()));
-}
-
-v8::Handle<v8::Array> V8SchemaRegistry::GetSchemas(
- const std::vector<std::string>& apis) {
- v8::Isolate* isolate = v8::Isolate::GetCurrent();
- v8::EscapableHandleScope handle_scope(isolate);
- v8::Context::Scope context_scope(GetOrCreateContext(isolate));
-
- v8::Local<v8::Array> v8_apis(v8::Array::New(isolate, apis.size()));
- size_t api_index = 0;
- for (std::vector<std::string>::const_iterator i = apis.begin();
- i != apis.end(); ++i) {
- v8_apis->Set(api_index++, GetSchema(*i));
- }
- return handle_scope.Escape(v8_apis);
-}
-
-v8::Handle<v8::Object> V8SchemaRegistry::GetSchema(const std::string& api) {
- if (schema_cache_ != NULL) {
- v8::Local<v8::Object> cached_schema = schema_cache_->Get(api);
- if (!cached_schema.IsEmpty()) {
- return cached_schema;
- }
- }
-
- // Slow path: Need to build schema first.
-
- v8::Isolate* isolate = v8::Isolate::GetCurrent();
- v8::EscapableHandleScope handle_scope(isolate);
- v8::Handle<v8::Context> context = GetOrCreateContext(isolate);
- v8::Context::Scope context_scope(context);
-
- const base::DictionaryValue* schema =
- ExtensionAPI::GetSharedInstance()->GetSchema(api);
- CHECK(schema) << api;
- scoped_ptr<V8ValueConverter> v8_value_converter(V8ValueConverter::create());
- v8::Handle<v8::Value> value = v8_value_converter->ToV8Value(schema, context);
- CHECK(!value.IsEmpty());
-
- v8::Local<v8::Object> v8_schema(v8::Handle<v8::Object>::Cast(value));
- schema_cache_->Set(api, v8_schema);
-
- return handle_scope.Escape(v8_schema);
-}
-
-v8::Handle<v8::Context> V8SchemaRegistry::GetOrCreateContext(
- v8::Isolate* isolate) {
- // It's ok to create local handles in this function, since this is only called
- // when we have a HandleScope.
- if (context_.IsEmpty()) {
- v8::Handle<v8::Context> context = v8::Context::New(isolate);
- context_.reset(context);
- schema_cache_.reset(new SchemaCache(isolate));
- return context;
- }
- return context_.NewHandle(isolate);
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698