Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2406013002: Reenable encrypted-media tests. (Closed)

Created:
4 years, 2 months ago by jrummell
Modified:
4 years, 2 months ago
Reviewers:
xhwang, ddorwin
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable encrypted-media tests. After https://codereview.chromium.org/2402563002/, the encrypted-media tests are no longer crashing, so reenabling them. BUG=652978, 653001 TEST=EME layout tests pass Committed: https://crrev.com/6be4d9fbc0b33047dfe901e2bbe2c322efda30cd Cr-Commit-Position: refs/heads/master@{#424297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jrummell
PTAL. Simply re-enabling the EME layout tests now that they're not crashing anymore.
4 years, 2 months ago (2016-10-10 22:49:24 UTC) #2
xhwang
Thank you! LGTM
4 years, 2 months ago (2016-10-10 22:56:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406013002/1
4 years, 2 months ago (2016-10-10 23:13:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 00:11:10 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:13:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6be4d9fbc0b33047dfe901e2bbe2c322efda30cd
Cr-Commit-Position: refs/heads/master@{#424297}

Powered by Google App Engine
This is Rietveld 408576698