Issue 2405973003: M54: Revert r414590

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2405973003: M54: Revert r414590 (Closed)

Created:
4 years, 2 months ago by Lei Zhang

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, asvitkine+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

M54: Revert r414590 Fixed the behaviour of form submit to match the standard: no submit is taken place when the form is detached from the document (e.g., form is removed). Reason for revert: Broke Cloud Print print job upload form. BUG=586749, 653692 Original code review: https://codereview.chromium.org/2261393002 Committed: https://chromium.googlesource.com/chromium/src/+/346142376c19b9744d684de17fff0382782b977e

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -36 lines)			Patch
D	third_party/WebKit/LayoutTests/fast/forms/submit-form-not-attached-to-document.html	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-cross-site-post.html	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/http/tests/cookies/same-site/popup-same-site-post.html	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/UseCounter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLFormElement.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Lei Zhang

4 years, 2 months ago (2016-10-10 23:59:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
346142376c19b9744d684de17fff0382782b977e.