Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2405953002: Support for Bazel workspaces in ContextBuilder. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support for Bazel workspaces in ContextBuilder. This replaces custom fileResolverProvider and packageResolverProvider that were used for the same purpose internally. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4c054212295f81a5aa9d0205f86d504423d8efdb

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -57 lines) Patch
M pkg/analyzer/lib/src/context/builder.dart View 3 chunks +20 lines, -26 lines 1 comment Download
M pkg/analyzer/test/src/context/builder_test.dart View 3 chunks +14 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-10 20:10:10 UTC) #1
Brian Wilkerson
lgtm, thanks! https://codereview.chromium.org/2405953002/diff/1/pkg/analyzer/lib/src/context/builder.dart File pkg/analyzer/lib/src/context/builder.dart (right): https://codereview.chromium.org/2405953002/diff/1/pkg/analyzer/lib/src/context/builder.dart#newcode232 pkg/analyzer/lib/src/context/builder.dart:232: // TODO(brianwilkerson) This doesn't support either embedder ...
4 years, 2 months ago (2016-10-10 20:47:43 UTC) #2
scheglov
4 years, 2 months ago (2016-10-10 20:51:56 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4c054212295f81a5aa9d0205f86d504423d8efdb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698