Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 240593004: cc: Fix missing compositor invalidations during resize (Closed)

Created:
6 years, 8 months ago by enne (OOO)
Modified:
6 years, 8 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org, danakj, ernstm
Visibility:
Public.

Description

cc: Fix missing compositor invalidations during resize In practice, cc is responsible for implicit invalidations on layers, such as the original layer being entirely invalid or new areas being exposed during resize. In this case, these invalidations were being clipped to the live tiles rect, which itself is clipped to the bounds of the tiling. Therefore, when the bounds of a layer grew, the new invalidation intersected with the old bounds was empty. The intersection of invalidations with the live tiles rect is an optimization, to prevent needless work trying to look up invalidations on parts of the layer that don't matter. To fix the bug, rather than intersecting with the live tiles rect, expand the live tiles rect to tile boundaries. This lets implicit invalidation due to resize within a tile not skip rerasterizing that tile. BUG=357120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265313

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Avoid assertion on empty bounds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -1 line) Patch
M cc/base/tiling_data.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/base/tiling_data.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M cc/base/tiling_data_unittest.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
enne (OOO)
6 years, 8 months ago (2014-04-17 00:23:16 UTC) #1
reveman
lgtm, thanks for the tests!
6 years, 8 months ago (2014-04-17 11:47:39 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 8 months ago (2014-04-17 16:36:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/240593004/1
6 years, 8 months ago (2014-04-17 16:37:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 17:52:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-17 17:52:15 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 8 months ago (2014-04-21 22:04:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/240593004/40001
6 years, 8 months ago (2014-04-21 22:05:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 23:04:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-21 23:04:07 UTC) #10
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 8 months ago (2014-04-21 23:07:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/240593004/40001
6 years, 8 months ago (2014-04-21 23:08:12 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-21 23:46:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-21 23:46:32 UTC) #14
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 8 months ago (2014-04-22 16:58:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/240593004/40001
6 years, 8 months ago (2014-04-22 16:59:04 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 18:53:19 UTC) #17
Message was sent while issue was closed.
Change committed as 265313

Powered by Google App Engine
This is Rietveld 408576698