Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2405903003: Make //mojo/edk/js a component. (Closed)

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make //mojo/edk/js a component. //mojo/edk/js is used by //content/renderer and //extensions/renderer, which are parts of separate components. Therefore it should also be a component. Committed: https://crrev.com/69b5942b77c4def26aaaa68f03adf5c00cd68144 Cr-Commit-Position: refs/heads/master@{#424573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M mojo/edk/js/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M mojo/edk/js/core.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/js/handle.h View 4 chunks +7 lines, -6 lines 0 comments Download
A mojo/edk/js/js_export.h View 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/edk/js/mojo_runner_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/js/support.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/js/threading.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Sam McNally
4 years, 2 months ago (2016-10-11 01:43:11 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-11 19:00:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405903003/1
4 years, 2 months ago (2016-10-11 22:28:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 22:35:13 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 22:38:14 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69b5942b77c4def26aaaa68f03adf5c00cd68144
Cr-Commit-Position: refs/heads/master@{#424573}

Powered by Google App Engine
This is Rietveld 408576698