Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2405863003: [Offline Pages] Fix PrerenderingLoader regression for handle a stop event from the prerender stack. (Closed)

Created:
4 years, 2 months ago by dougarnett
Modified:
4 years, 2 months ago
Reviewers:
Pete Williamson, romax
CC:
chromium-reviews, cbentzel+watch_chromium.org, dewittj+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, gavinp+prer_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Fix PrerenderingLoader regression for handle a stop event from the prerender stack. BUG=654555 Committed: https://crrev.com/492403bb5d8d52e7bc7b3e4bd5f73b4b959349c3 Cr-Commit-Position: refs/heads/master@{#424439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M chrome/browser/android/offline_pages/prerendering_loader.cc View 1 chunk +23 lines, -19 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_loader_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
dougarnett
4 years, 2 months ago (2016-10-10 22:10:11 UTC) #4
Pete Williamson
lgtm
4 years, 2 months ago (2016-10-10 22:16:24 UTC) #5
romax
lgtm thanks for the quick fix!
4 years, 2 months ago (2016-10-10 22:32:33 UTC) #6
dewittj
nit: keep commit messages Git-friendly by limiting lines to 80 chars https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list-descriptions Thanks :)
4 years, 2 months ago (2016-10-10 22:37:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405863003/1
4 years, 2 months ago (2016-10-11 15:43:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 15:48:38 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 15:51:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/492403bb5d8d52e7bc7b3e4bd5f73b4b959349c3
Cr-Commit-Position: refs/heads/master@{#424439}

Powered by Google App Engine
This is Rietveld 408576698