Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 240583006: Added device types (bluetooth, usb, serio) to InputDeviceInfo. (Closed)

Created:
6 years, 8 months ago by ygorshenin1
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added device types (bluetooth, usb, serio) to InputDeviceInfo. BUG=357050 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265228

Patch Set 1 #

Patch Set 2 : Rebase, slightly modified tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M chrome/browser/chromeos/device/input_service_proxy_browsertest.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M device/hid/input_service_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/hid/input_service_linux.cc View 5 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ygorshenin1
6 years, 8 months ago (2014-04-17 12:12:06 UTC) #1
ygorshenin1
Ken, could you please take a look?
6 years, 8 months ago (2014-04-20 11:23:45 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 8 months ago (2014-04-21 20:31:11 UTC) #3
ygorshenin1
+ Nikita for chrome/browser/chromeos/*
6 years, 8 months ago (2014-04-22 09:06:08 UTC) #4
Nikita (slow)
lgtm
6 years, 8 months ago (2014-04-22 09:14:00 UTC) #5
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 8 months ago (2014-04-22 09:14:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/240583006/20001
6 years, 8 months ago (2014-04-22 09:14:33 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 11:21:16 UTC) #8
Message was sent while issue was closed.
Change committed as 265228

Powered by Google App Engine
This is Rietveld 408576698