|
Revert 264313 "Add activity recording capability to gcm internal..."
This caused a compile error on the Win x64 builder:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17353/steps/compile/logs/stdio
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj.rsp /c ..\..\google_apis\gcm\tools\mcs_probe.cc /Foobj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj /Fdobj\google_apis\gcm\mcs_probe.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\google_apis\gcm\tools\mcs_probe.cc(309) :error C2661: 'gcm::MCSClient::MCSClient' : no overloaded function takes 4 arguments
ninja: build stopped: subcommand failed.
> Add activity recording capability to gcm internals page. User can refresh, start/stop recording, and clear recording logs.
> Also added more information to the device info section and fixed a bug there.
>
> arv: owner review of chrome/browser/resources/*.
> jianli & fgorski please review the rest of the code, and zea for owner review of these code.
>
> BUG= 341256
>
> Review URL: https://codereview.chromium.org/202083005
TBR=juyik@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264319
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+73 lines, -834 lines) |
Patch |
 |
M |
trunk/src/chrome/browser/resources/gcm_internals.css
|
View
|
|
1 chunk |
+3 lines, -19 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/resources/gcm_internals.html
|
View
|
|
1 chunk |
+19 lines, -63 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/resources/gcm_internals.js
|
View
|
|
4 chunks |
+2 lines, -80 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/services/gcm/gcm_client_mock.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/services/gcm/gcm_client_mock.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/services/gcm/gcm_profile_service.h
|
View
|
|
4 chunks |
+7 lines, -12 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/services/gcm/gcm_profile_service.cc
|
View
|
|
5 chunks |
+10 lines, -43 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/ui/webui/gcm_internals_ui.cc
|
View
|
|
6 chunks |
+4 lines, -87 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/engine/checkin_request.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/engine/gcm_store.h
|
View
|
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/engine/mcs_client.h
|
View
|
|
6 chunks |
+3 lines, -21 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/engine/mcs_client.cc
|
View
|
|
6 chunks |
+1 line, -24 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/engine/mcs_client_unittest.cc
|
View
|
|
4 chunks |
+3 lines, -8 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/gcm.gyp
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/gcm_client.h
|
View
|
|
3 chunks |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/gcm_client.cc
|
View
|
|
1 chunk |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/gcm_client_impl.h
|
View
|
|
5 chunks |
+1 line, -13 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/gcm_client_impl.cc
|
View
|
|
6 chunks |
+5 lines, -31 lines |
0 comments
|
Download
|
 |
M |
trunk/src/google_apis/gcm/gcm_client_impl_unittest.cc
|
View
|
|
5 chunks |
+6 lines, -12 lines |
0 comments
|
Download
|
 |
D |
trunk/src/google_apis/gcm/monitoring/gcm_stats_recorder.h
|
View
|
|
1 chunk |
+0 lines, -101 lines |
0 comments
|
Download
|
 |
D |
trunk/src/google_apis/gcm/monitoring/gcm_stats_recorder.cc
|
View
|
|
1 chunk |
+0 lines, -150 lines |
0 comments
|
Download
|
 |
D |
trunk/src/google_apis/gcm/monitoring/gcm_stats_recorder_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -136 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|