Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2405803003: Replace RunLoop with WaitableEvent in ConditionalCacheDeletionHelperBrowserTest (Closed)

Created:
4 years, 2 months ago by msramek
Modified:
4 years, 2 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace RunLoop with WaitableEvent in ConditionalCacheDeletionHelperBrowserTest ...to synchronize the UI and IO threads. WaitableEvent correctly handles the situation where the waited IO thread tasks finishes first (i.e. Signal() is called first, Wait() later) which was not the case in the previous implementation with RunLoop(). BUG=651505 Committed: https://crrev.com/5263a0fd408925936e119912e6a7c318413861d9 Cr-Commit-Position: refs/heads/master@{#424136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
msramek
Hi Václav, Could you please have a quick look? This is hopefully relatively context-free. I ...
4 years, 2 months ago (2016-10-10 12:49:06 UTC) #6
vabr (Chromium)
LGTM, nice! Vaclav
4 years, 2 months ago (2016-10-10 13:00:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405803003/1
4 years, 2 months ago (2016-10-10 13:03:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 13:08:48 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 13:11:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5263a0fd408925936e119912e6a7c318413861d9
Cr-Commit-Position: refs/heads/master@{#424136}

Powered by Google App Engine
This is Rietveld 408576698