Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2405793002: documentStyleSheetCollection() is always non-null. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

documentStyleSheetCollection() is always non-null. Return a reference instead of a pointer to make that clear. R=meade@chromium.org Committed: https://crrev.com/0f730f6cf16d3a863131408535af57b339ff00a9 Cr-Commit-Position: refs/heads/master@{#424706}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary get()s. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 7 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
rune
ptal
4 years, 2 months ago (2016-10-10 14:20:03 UTC) #5
meade_UTC10
lgtm https://codereview.chromium.org/2405793002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.h File third_party/WebKit/Source/core/dom/StyleEngine.h (right): https://codereview.chromium.org/2405793002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.h#newcode260 third_party/WebKit/Source/core/dom/StyleEngine.h:260: return *m_documentStyleSheetCollection.get(); The .get seems redundant - can ...
4 years, 2 months ago (2016-10-11 05:53:24 UTC) #6
rune
https://codereview.chromium.org/2405793002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.h File third_party/WebKit/Source/core/dom/StyleEngine.h (right): https://codereview.chromium.org/2405793002/diff/1/third_party/WebKit/Source/core/dom/StyleEngine.h#newcode260 third_party/WebKit/Source/core/dom/StyleEngine.h:260: return *m_documentStyleSheetCollection.get(); On 2016/10/11 05:53:24, Eddy wrote: > The ...
4 years, 2 months ago (2016-10-12 09:19:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405793002/20001
4 years, 2 months ago (2016-10-12 09:19:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 10:39:20 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 10:41:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f730f6cf16d3a863131408535af57b339ff00a9
Cr-Commit-Position: refs/heads/master@{#424706}

Powered by Google App Engine
This is Rietveld 408576698