Removed ref churn from Document::getNonAttachedStyle.

Removed ref churn from Document::getNonAttachedStyle.

Removed the creation of a new local RefPtr object which
creates ref churn.

BUG=595137
Committed: https://crrev.com/4b9833ae2deefd124a268633ff6054a69ef43bf4
Cr-Commit-Position: refs/heads/master@{#425599}

[Bugs Nash, 2016-10-10 02:55:27]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 02:55:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2016-10-10 02:56:05]

Description was changed from

==========
Removed ref churn from Document::getNonAttachedStyle.

BUG=595137
==========

to

==========
Removed ref churn from Document::getNonAttachedStyle.

Removed the creation of a new local RefPtr object which
creates ref churn.

BUG=595137
==========

[Bugs Nash, 2016-10-10 02:56:16]

bugsnash@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2016-10-10 03:18:38]

lgtm

[blink-reviews, 2016-10-10 03:18:40]

lgtm

On Mon, Oct 10, 2016 at 1:56 PM <bugsnash@chromium.org> wrote:

> Reviewers: nainar
> CL: https://codereview.chromium.org/2405753002/
>
> Description:
> Removed ref churn from Document::getNonAttachedStyle.
>
> Removed the creation of a new local RefPtr object which
> creates ref churn.
>
> BUG=595137
>
> Affected files (+1, -2 lines):
> M third_party/WebKit/Source/core/dom/Document.cpp
>
>
> Index: third_party/WebKit/Source/core/dom/Document.cpp
> diff --git a/third_party/WebKit/Source/core/dom/Document.cpp
> b/third_party/WebKit/Source/core/dom/Document.cpp
> index
>
083ed51d91f4be61eec1603eeb3ac754d5ea3198..b9c15a796333dd6ca0af74568997e9f56ff8c095
> 100644
> --- a/third_party/WebKit/Source/core/dom/Document.cpp
> +++ b/third_party/WebKit/Source/core/dom/Document.cpp
> @@ -1255,8 +1255,7 @@ void Document::addNonAttachedStyle(Element& element,
> }
>
> ComputedStyle* Document::getNonAttachedStyle(Element& element) {
> - RefPtr<ComputedStyle> style = m_nonAttachedStyle.get(&element);
> - return style.get();
> + return m_nonAttachedStyle.get(&element);
> }
>
> /*
>
>
> --
Regards,
Naina

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-10-10 03:18:41]

lgtm

On Mon, Oct 10, 2016 at 1:56 PM <bugsnash@chromium.org> wrote:

> Reviewers: nainar
> CL: https://codereview.chromium.org/2405753002/
>
> Description:
> Removed ref churn from Document::getNonAttachedStyle.
>
> Removed the creation of a new local RefPtr object which
> creates ref churn.
>
> BUG=595137
>
> Affected files (+1, -2 lines):
> M third_party/WebKit/Source/core/dom/Document.cpp
>
>
> Index: third_party/WebKit/Source/core/dom/Document.cpp
> diff --git a/third_party/WebKit/Source/core/dom/Document.cpp
> b/third_party/WebKit/Source/core/dom/Document.cpp
> index
>
083ed51d91f4be61eec1603eeb3ac754d5ea3198..b9c15a796333dd6ca0af74568997e9f56ff8c095
> 100644
> --- a/third_party/WebKit/Source/core/dom/Document.cpp
> +++ b/third_party/WebKit/Source/core/dom/Document.cpp
> @@ -1255,8 +1255,7 @@ void Document::addNonAttachedStyle(Element& element,
> }
>
> ComputedStyle* Document::getNonAttachedStyle(Element& element) {
> - RefPtr<ComputedStyle> style = m_nonAttachedStyle.get(&element);
> - return style.get();
> + return m_nonAttachedStyle.get(&element);
> }
>
> /*
>
>
> --
Regards,
Naina

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bugs Nash, 2016-10-10 03:32:39]

bugsnash@chromium.org changed reviewers:
+ esprehn@chromium.org

[commit-bot: I haz the power, 2016-10-10 04:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 04:57:57]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-10-14 07:49:58]

lgtm

[Bugs Nash, 2016-10-16 21:50:06]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2016-10-16 21:50:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 23:06:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-16 23:08:59]

Description was changed from

==========
Removed ref churn from Document::getNonAttachedStyle.

Removed the creation of a new local RefPtr object which
creates ref churn.

BUG=595137
==========

to

==========
Removed ref churn from Document::getNonAttachedStyle.

Removed the creation of a new local RefPtr object which
creates ref churn.

BUG=595137

Committed: https://crrev.com/4b9833ae2deefd124a268633ff6054a69ef43bf4
Cr-Commit-Position: refs/heads/master@{#425599}
==========

[commit-bot: I haz the power, 2016-10-16 23:09:00]

Patchset 1 (id:??) landed as
https://crrev.com/4b9833ae2deefd124a268633ff6054a69ef43bf4
Cr-Commit-Position: refs/heads/master@{#425599}