Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2405743002: X87: Skip MultiReturnSelect_f32/MultiReturnSelect_f64 tests. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Skip MultiReturnSelect_f32/MultiReturnSelect_f64 tests. The CL #39795 (https://codereview.chromium.org/2345593003 ) added MultiReturnSelect_f32/MultiReturnSelect_f64 tests. Because those tests need 2 float point return registers and x87 only has 1 FP return register, Those tests failed at x87 port. This CL skips MultiReturnSelect_f32/MultiReturnSelect_f64 tests for x87. BUG= Committed: https://crrev.com/b600ea0672d300e3d32df873c1e97c5977919083 Cr-Commit-Position: refs/heads/master@{#40113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-10 02:33:45 UTC) #2
titzer
On 2016/10/10 02:33:45, zhengxing.li wrote: > PTAL, thanks! This is OK to disable for now, ...
4 years, 2 months ago (2016-10-10 08:36:14 UTC) #3
zhengxing.li
On 2016/10/10 08:36:14, titzer wrote: > On 2016/10/10 02:33:45, zhengxing.li wrote: > > PTAL, thanks! ...
4 years, 2 months ago (2016-10-10 09:05:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405743002/1
4 years, 2 months ago (2016-10-10 09:07:28 UTC) #6
titzer
On 2016/10/10 09:05:26, zhengxing.li wrote: > On 2016/10/10 08:36:14, titzer wrote: > > On 2016/10/10 ...
4 years, 2 months ago (2016-10-10 09:17:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 09:30:41 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 09:30:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b600ea0672d300e3d32df873c1e97c5977919083
Cr-Commit-Position: refs/heads/master@{#40113}

Powered by Google App Engine
This is Rietveld 408576698