Let the disable-default-apps option suppress Files.app launch reacting to mount of external devices.

Let the disable-default-apps option suppress Files.app launch reacting to mount of external devices.

Currently Files.app is launched reacting to mount of external devices such as
USB, which make some manual tests inconvinient.  This CL suppress the behavior
by the disable-default-apps option that has been used to suppress the start page
application.

BUG=259812
TEST=launch Files.app with the switch, call the mount event manually via the inspector

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222013

[hirono, 2013-09-09 06:06:56]

Could you take a look the CL?
Thank you very much!

[yoshiki, 2013-09-09 08:16:54]

lgtm with nits

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/background.js (right):

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/background.js:406: var launchEnable =
true;
nit: no need to set to true? I think either null or undefined is better in case
of debug.

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/background.js:408: if (action !=
'auto-open') {
nit: Why we skip this step if 'auto-open'? Please add a brief comment.

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/background.js:422: return;
nit: add a blank line

[hirono, 2013-09-09 08:28:33]

Thanks!

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/background.js (right):

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/background.js:406: var launchEnable =
true;
On 2013/09/09 08:16:54, yoshiki wrote:
> nit: no need to set to true? I think either null or undefined is better in
case
> of debug.

Done.

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/background.js:408: if (action !=
'auto-open') {
On 2013/09/09 08:16:54, yoshiki wrote:
> nit: Why we skip this step if 'auto-open'? Please add a brief comment.

Done.

https://codereview.chromium.org/24057006/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/background.js:422: return;
On 2013/09/09 08:16:54, yoshiki wrote:
> nit: add a blank line

Done.

[commit-bot: I haz the power, 2013-09-09 08:28:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/24057006/6001

[commit-bot: I haz the power, 2013-09-09 09:26:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/24057006/23001

[commit-bot: I haz the power, 2013-09-09 12:34:22]

Change committed as 222013