third_party/libtiff/tif_aux.c - Issue 2405693002: libtiff: Prevent a buffer overflow in function ChopUpSingleUncompressedStrip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libtiff/tif_aux.c

Issue 2405693002: libtiff: Prevent a buffer overflow in function ChopUpSingleUncompressedStrip. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libtiff/tif_aux.c

diff --git a/third_party/libtiff/tif_aux.c b/third_party/libtiff/tif_aux.c

index 3ce3680ab2ae23cd86654230d47b2aaf81c18955..bc4ea0192815137f2d55031e70fbd0ee2d130d9e 100644

--- a/third_party/libtiff/tif_aux.c

+++ b/third_party/libtiff/tif_aux.c

@@ -69,7 +69,7 @@ _TIFFCheckRealloc(TIFF* tif, void* buffer,

* XXX: Check for integer overflow.

- if (nmemb && elem_size && !_TIFFIfMultiplicationOverflow(nmemb, elem_size))

+ if (nmemb > 0 && elem_size > 0 && !_TIFFIfMultiplicationOverflow(nmemb, elem_size))

hong_zhang 2016/10/17 18:07:38 Hi, may I ask why? I thought tmsize_t is unsigned.

Tom Sepez 2016/10/17 18:20:04 nmemb is tmsize_t. tmsize_t is TIFF_SSIZE_T at h

cp = _TIFFrealloc(buffer, bytes);

if (cp == NULL) {

« no previous file with comments | « third_party/libtiff/README.pdfium ('k') | no next file » | no next file with comments »