third_party/libtiff/0008-HeapBufferOverflow-ChopUpSingleUncompressedStrip.patch - Issue 2405693002: libtiff: Prevent a buffer overflow in function ChopUpSingleUncompressedStrip.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libtiff/0008-HeapBufferOverflow-ChopUpSingleUncompressedStrip.patch

Issue 2405693002: libtiff: Prevent a buffer overflow in function ChopUpSingleUncompressedStrip. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/libtiff/tif_aux.c b/third_party/libtiff/tif_aux.c

	2 index 3ce3680..bc4ea01 100644

	3 --- a/third_party/libtiff/tif_aux.c

	4 +++ b/third_party/libtiff/tif_aux.c

	5 @@ -69,7 +69,7 @@ _TIFFCheckRealloc(TIFF* tif, void* buffer,

	6 /*

	7 * XXX: Check for integer overflow.

	8 */

	9 - if (nmemb && elem_size && !_TIFFIfMultiplicationOverflow(nmemb, elem_siz e))

	10 + if (nmemb > 0 && elem_size > 0 && !_TIFFIfMultiplicationOverflow(nmemb, elem_size))

	11 cp = _TIFFrealloc(buffer, bytes);

	12

	13 if (cp == NULL) {

OLD	NEW

« no previous file with comments | « no previous file | third_party/libtiff/README.pdfium » ('j') | third_party/libtiff/tif_aux.c » ('J')