Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2405643002: MD Settings: Restore paper-input label for adding new startup URL. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore paper-input label for adding new startup URL. BUG=619793 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/87fb747eb383344af52e4831ee0dae8b62b3334c Cr-Commit-Position: refs/heads/master@{#424038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
dpapad
Bug was accidentally introduced at https://codereview.chromium.org/1869883003. See before/after screenshots at http://imgur.com/a/2bBHN.
4 years, 2 months ago (2016-10-08 00:27:17 UTC) #3
dschuyler
lgtm
4 years, 2 months ago (2016-10-08 00:31:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405643002/1
4 years, 2 months ago (2016-10-08 00:38:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 01:44:26 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 01:46:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87fb747eb383344af52e4831ee0dae8b62b3334c
Cr-Commit-Position: refs/heads/master@{#424038}

Powered by Google App Engine
This is Rietveld 408576698