Extract SandboxIPCProcess into its own file.

Extract SandboxIPCProcess into its own file.

This is the first step to turning SandboxIPCProcess into a thread
in the browser process.

BUG=322185
TEST=Chrome builds and loads web pages.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265836

[Jorge Lucangeli Obes, 2014-04-17 00:22:03]

jln: It's gonna be hard to convert SandboxIPCProcess to a thread as long as it's
inside another file. However, this code has includes that would not pass deps
today (this code hasn't changed in a while). I might need to do more
refactoring.

[jln (very slow on Chromium), 2014-04-17 00:28:37]

lgtm with nits.

- Rename the files as _linux.* or you will have issue on non Linux try bots.
- I'm owner of render_sandbox_host_linux.*, please add sandbox_ipc_linux.* as
well

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
File content/browser/renderer_host/sandbox_ipc.cc (right):

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
No (c), just "Copyright 2014"

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
This file should be sandbox_ipc_linux.cc

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:126: }
// namespace

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:664: }
// namespace content

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
File content/browser/renderer_host/sandbox_ipc.h (right):

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.h:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
No (c) in new files, just "Copyright 2014"

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.h:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
This file should be sandbox_ipc_linux.h

[Jorge Lucangeli Obes, 2014-04-23 00:38:57]

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
File content/browser/renderer_host/sandbox_ipc.cc (right):

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/04/17 00:28:37, jln wrote:
> No (c), just "Copyright 2014"

Done.

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/04/17 00:28:37, jln wrote:
> This file should be sandbox_ipc_linux.cc

Done.

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:126: }
On 2014/04/17 00:28:37, jln wrote:
> // namespace

Done.

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.cc:664: }
On 2014/04/17 00:28:37, jln wrote:
> // namespace content

Done.

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
File content/browser/renderer_host/sandbox_ipc.h (right):

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.h:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/04/17 00:28:37, jln wrote:
> No (c) in new files, just "Copyright 2014"

Done.

https://chromiumcodereview.appspot.com/240563002/diff/20001/content/browser/r...
content/browser/renderer_host/sandbox_ipc.h:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/04/17 00:28:37, jln wrote:
> This file should be sandbox_ipc_linux.h

Done.

[Jorge Lucangeli Obes, 2014-04-23 00:43:04]

Antoine: this CL is only extracting code in preparation for a refactor that will
get rid of the Sandbox IPC as an extra process.

This is triggering deps checks because the code hasn't been touched in years. I
would like to extract the code without modification and then remove whatever
deps I can remove. That would imply landing this CL ignoring those check_deps
errors. Do you think that's reasonable?

Thanks!

[piman, 2014-04-23 00:51:58]

On 2014/04/23 00:43:04, Jorge Lucangeli Obes wrote:
> Antoine: this CL is only extracting code in preparation for a refactor that
will
> get rid of the Sandbox IPC as an extra process.
> 
> This is triggering deps checks because the code hasn't been touched in years.
I
> would like to extract the code without modification and then remove whatever
> deps I can remove. That would imply landing this CL ignoring those check_deps
> errors. Do you think that's reasonable?
> 
> Thanks!

What kind of deps error do you get?
Can we just add those deps, with a comment/bug to remove them?

[Jorge Lucangeli Obes, 2014-04-23 16:19:59]

On 2014/04/23 00:51:58, piman wrote:
> On 2014/04/23 00:43:04, Jorge Lucangeli Obes wrote:
> > Antoine: this CL is only extracting code in preparation for a refactor that
> will
> > get rid of the Sandbox IPC as an extra process.
> > 
> > This is triggering deps checks because the code hasn't been touched in
years.
> I
> > would like to extract the code without modification and then remove whatever
> > deps I can remove. That would imply landing this CL ignoring those
check_deps
> > errors. Do you think that's reasonable?
> > 
> > Thanks!
> 
> What kind of deps error do you get?
> Can we just add those deps, with a comment/bug to remove them?

I should have been more clear. The problem is that the old code has invalid
includes:

You added one or more #includes that violate checkdeps rules.
  content/browser/renderer_host/sandbox_ipc_linux.cc
      Illegal include: "third_party/WebKit/public/platform/linux/WebFontInfo.h"
    Because of "-third_party/WebKit" from content/browser's include_rules. \
  content/browser/renderer_host/sandbox_ipc_linux.cc
      Illegal include: "third_party/WebKit/public/web/WebKit.h"
    Because of "-third_party/WebKit" from content/browser's include_rules. \
  content/browser/renderer_host/sandbox_ipc_linux.h
      Illegal include: "content/child/blink_platform_impl.h"
    Because of "-content" from content's include_rules.

[jln (very slow on Chromium), 2014-04-23 20:40:09]

On 2014/04/23 16:19:59, Jorge Lucangeli Obes wrote:
> On 2014/04/23 00:51:58, piman wrote:
> > On 2014/04/23 00:43:04, Jorge Lucangeli Obes wrote:
> > > Antoine: this CL is only extracting code in preparation for a refactor
that
> > will
> > > get rid of the Sandbox IPC as an extra process.
> > > 
> > > This is triggering deps checks because the code hasn't been touched in
> years.
> > I
> > > would like to extract the code without modification and then remove
whatever
> > > deps I can remove. That would imply landing this CL ignoring those
> check_deps
> > > errors. Do you think that's reasonable?
> > > 
> > > Thanks!
> > 
> > What kind of deps error do you get?
> > Can we just add those deps, with a comment/bug to remove them?
> 
> I should have been more clear. The problem is that the old code has invalid
> includes:
> 
> You added one or more #includes that violate checkdeps rules.
>   content/browser/renderer_host/sandbox_ipc_linux.cc
>       Illegal include:
"third_party/WebKit/public/platform/linux/WebFontInfo.h"
>     Because of "-third_party/WebKit" from content/browser's include_rules. \
>   content/browser/renderer_host/sandbox_ipc_linux.cc
>       Illegal include: "third_party/WebKit/public/web/WebKit.h"
>     Because of "-third_party/WebKit" from content/browser's include_rules. \
>   content/browser/renderer_host/sandbox_ipc_linux.h
>       Illegal include: "content/child/blink_platform_impl.h"
>     Because of "-content" from content's include_rules.

If you look at //content/browser/renderer_host/DEPS, you'll see:

  "render_sandbox_host_linux\.cc": [
    "+content/child/blink_platform_impl.h",
    "+third_party/WebKit/public/platform/linux/WebFontInfo.h",
    "+third_party/WebKit/public/web/WebKit.h",
  ],

It looks like you simply needs to move this to sandbox_ipc_linux.cc instead.

[Jorge Lucangeli Obes, 2014-04-23 20:47:50]

On 2014/04/23 20:40:09, jln wrote:
> On 2014/04/23 16:19:59, Jorge Lucangeli Obes wrote:
> > On 2014/04/23 00:51:58, piman wrote:
> > > On 2014/04/23 00:43:04, Jorge Lucangeli Obes wrote:
> > > > Antoine: this CL is only extracting code in preparation for a refactor
> that
> > > will
> > > > get rid of the Sandbox IPC as an extra process.
> > > > 
> > > > This is triggering deps checks because the code hasn't been touched in
> > years.
> > > I
> > > > would like to extract the code without modification and then remove
> whatever
> > > > deps I can remove. That would imply landing this CL ignoring those
> > check_deps
> > > > errors. Do you think that's reasonable?
> > > > 
> > > > Thanks!
> > > 
> > > What kind of deps error do you get?
> > > Can we just add those deps, with a comment/bug to remove them?
> > 
> > I should have been more clear. The problem is that the old code has invalid
> > includes:
> > 
> > You added one or more #includes that violate checkdeps rules.
> >   content/browser/renderer_host/sandbox_ipc_linux.cc
> >       Illegal include:
> "third_party/WebKit/public/platform/linux/WebFontInfo.h"
> >     Because of "-third_party/WebKit" from content/browser's include_rules. \
> >   content/browser/renderer_host/sandbox_ipc_linux.cc
> >       Illegal include: "third_party/WebKit/public/web/WebKit.h"
> >     Because of "-third_party/WebKit" from content/browser's include_rules. \
> >   content/browser/renderer_host/sandbox_ipc_linux.h
> >       Illegal include: "content/child/blink_platform_impl.h"
> >     Because of "-content" from content's include_rules.
> 
> If you look at //content/browser/renderer_host/DEPS, you'll see:
> 
>   "render_sandbox_host_linux\.cc": [
>     "+content/child/blink_platform_impl.h",
>     "+third_party/WebKit/public/platform/linux/WebFontInfo.h",
>     "+third_party/WebKit/public/web/WebKit.h",
>   ],
> 
> It looks like you simply needs to move this to sandbox_ipc_linux.cc instead.

A-ha! I thought it was a global setting, not per-file. I'll change that.

[Jorge Lucangeli Obes, 2014-04-23 21:45:57]

Updated DEPS, PTAL.

[Jorge Lucangeli Obes, 2014-04-23 23:12:29]

Scott for content/browser OWNERS.

I'm extracting a class that was fully declared inside
render_sandbox_host_linux.cc into its own .cc/.h files. No code changes at this
time.

[piman, 2014-04-24 00:04:14]

lgtm

[Jorge Lucangeli Obes, 2014-04-24 01:00:01]

The CQ bit was checked by jorgelo@chromium.org

[commit-bot: I haz the power, 2014-04-24 01:00:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/240563002/60001

[sky, 2014-04-24 03:21:30]

piman owns all these files, so you don't need me:
-sky

[commit-bot: I haz the power, 2014-04-24 03:34:18]

Change committed as 265836