swarming: Enable USB resets in python-adb on the staging instance.

swarming: Enable USB resets in python-adb on the staging instance.

BUG=642440
Committed: https://github.com/luci/luci-py/commit/8c84f5406cf6ff9587e17e1b3b44456dcb533707

[bpastene, 2016-10-07 22:57:58]

bpastene@chromium.org changed reviewers:
+ maruel@chromium.org, stip@chromium.org

[bpastene, 2016-10-07 22:57:58]

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/api/platforms/android.py (right):

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/api/platforms/android.py:114: enable_resets =
bot.server and '-dev' in bot.server
Anyone know a better is_staging check?

[ghost stip (do not use), 2016-10-07 23:50:26]

lgtm

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/api/platforms/android.py (right):

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/api/platforms/android.py:114: enable_resets =
bot.server and '-dev' in bot.server
On 2016/10/07 22:57:58, bpastene wrote:
> Anyone know a better is_staging check?

IIRC this is correct but double-check with maruel

[M-A Ruel, 2016-10-11 19:34:02]

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/api/platforms/android.py (right):

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/api/platforms/android.py:114: enable_resets =
bot.server and '-dev' in bot.server
On 2016/10/07 23:50:26, stip wrote:
> On 2016/10/07 22:57:58, bpastene wrote:
> > Anyone know a better is_staging check?
> 
> IIRC this is correct but double-check with maruel

Make it a flag, use bot_config.is_staging() to pass this flag. Add the function
back, it was removed in https://chromereviews.googleplex.com/491247013.

[bpastene, 2016-10-11 20:09:53]

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/api/platforms/android.py (right):

https://codereview.chromium.org/2405613002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/api/platforms/android.py:114: enable_resets =
bot.server and '-dev' in bot.server
On 2016/10/11 19:34:02, M-A Ruel wrote:
> Make it a flag, use bot_config.is_staging() to pass this flag. Add the
function
> back, it was removed in https://chromereviews.googleplex.com/491247013.

Done: https://chromereviews.googleplex.com/519447013/

[bpastene, 2016-10-14 19:32:34]

Going to land this, then push the bot_config change.

[bpastene, 2016-10-14 19:34:01]

The CQ bit was checked by bpastene@chromium.org

[bpastene, 2016-10-14 19:34:01]

The patchset sent to the CQ was uploaded after l-g-t-m from stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2405613002/#ps20001
(title: "move is_staging check to bot_config")

[commit-bot: I haz the power, 2016-10-14 19:34:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:37:40]

Description was changed from

==========
swarming: Enable USB resets in python-adb on the staging instance.

BUG=642440
==========

to

==========
swarming: Enable USB resets in python-adb on the staging instance.

BUG=642440

Committed:
https://github.com/luci/luci-py/commit/8c84f5406cf6ff9587e17e1b3b44456dcb533707
==========

[commit-bot: I haz the power, 2016-10-14 19:37:41]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/8c84f5406cf6ff9587e17e1b3b44456dcb533707