Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2405603003: [modules] Extend a namespace test. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Extend a namespace test. Extend a test of namespace imports such that it accesses the object inside a with statement (inside a sloppy function). Drive-by-fix: remove duplicate initialization of embedder data (probably due to bad merge). R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/9606a938a687ad8ff52e7b072c22ea25f716321a Cr-Commit-Position: refs/heads/master@{#40129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M src/factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/modules-namespace4.js View 2 chunks +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
neis
4 years, 2 months ago (2016-10-08 11:25:40 UTC) #1
adamk
lgtm (and those tests are...impressive)
4 years, 2 months ago (2016-10-10 16:22:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405603003/1
4 years, 2 months ago (2016-10-10 16:31:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 16:56:25 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 16:56:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9606a938a687ad8ff52e7b072c22ea25f716321a
Cr-Commit-Position: refs/heads/master@{#40129}

Powered by Google App Engine
This is Rietveld 408576698