Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2405533002: Revert "Mark APK downloads as dangerous on Android" (Closed)

Created:
4 years, 2 months ago by Nathan Parker
Modified:
4 years, 2 months ago
Reviewers:
asanka
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Mark APK downloads as dangerous on Android" This reverts commit a82b8f2fdf6f365cb38c8792ec67f420cd762db4, but increments the version number since we should only go up. BUG=652907 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/84c632df136adb79c1282df0509daff8747e088c Cr-Commit-Position: refs/heads/master@{#423995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/resources/safe_browsing/download_file_types.asciipb View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nathan Parker
4 years, 2 months ago (2016-10-07 17:20:21 UTC) #3
asanka
lgtm
4 years, 2 months ago (2016-10-07 18:14:30 UTC) #4
asanka
On 2016/10/07 at 18:14:30, asanka wrote: > lgtm Although we should verify what's going on. ...
4 years, 2 months ago (2016-10-07 18:15:05 UTC) #5
Nathan Parker
Yup, there are other issues here, but I think APK is the most common one ...
4 years, 2 months ago (2016-10-07 21:03:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405533002/1
4 years, 2 months ago (2016-10-07 21:03:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 22:53:25 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 22:55:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84c632df136adb79c1282df0509daff8747e088c
Cr-Commit-Position: refs/heads/master@{#423995}

Powered by Google App Engine
This is Rietveld 408576698