Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: tools/gn.py

Issue 2405513002: GN: Disable clang for simulators hosted on ia32 (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/tcmalloc/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2016 The Dart project authors. All rights reserved. 2 # Copyright 2016 The Dart project authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import multiprocessing 7 import multiprocessing
8 import os 8 import os
9 import subprocess 9 import subprocess
10 import sys 10 import sys
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 # This setting is only meaningful for Flutter. Standalone builds of the VM 99 # This setting is only meaningful for Flutter. Standalone builds of the VM
100 # should leave this set to 'develop', which causes the build to defer to 100 # should leave this set to 'develop', which causes the build to defer to
101 # 'is_debug', 'is_release' and 'is_product'. 101 # 'is_debug', 'is_release' and 'is_product'.
102 gn_args['dart_runtime_mode'] = 'develop' 102 gn_args['dart_runtime_mode'] = 'develop'
103 103
104 # TODO(zra): Investigate using clang with these configurations. 104 # TODO(zra): Investigate using clang with these configurations.
105 # Clang compiles tcmalloc's inline assembly for ia32 on Linux wrong, so we 105 # Clang compiles tcmalloc's inline assembly for ia32 on Linux wrong, so we
106 # don't use clang in that configuration. 106 # don't use clang in that configuration.
107 has_clang = (host_os != 'win' 107 has_clang = (host_os != 'win'
108 and args.os not in ['android'] 108 and args.os not in ['android']
109 and not (gn_args['target_os'] == 'linux' and arch == 'ia32') 109 and not (gn_args['target_os'] == 'linux' and
110 gn_args['host_cpu'] == 'x86')
110 and not gn_args['target_cpu'].startswith('arm') 111 and not gn_args['target_cpu'].startswith('arm')
111 and not gn_args['target_cpu'].startswith('mips')) 112 and not gn_args['target_cpu'].startswith('mips'))
112 gn_args['is_clang'] = args.clang and has_clang 113 gn_args['is_clang'] = args.clang and has_clang
113 114
114 gn_args['is_asan'] = args.asan and gn_args['is_clang'] 115 gn_args['is_asan'] = args.asan and gn_args['is_clang']
115 116
116 if args.target_sysroot: 117 if args.target_sysroot:
117 gn_args['target_sysroot'] = args.target_sysroot 118 gn_args['target_sysroot'] = args.target_sysroot
118 119
119 if args.toolchain_prefix: 120 if args.toolchain_prefix:
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 return 1 313 return 1
313 314
314 endtime = time.time() 315 endtime = time.time()
315 if args.verbose: 316 if args.verbose:
316 print ("GN Time: %.3f seconds" % (endtime - starttime)) 317 print ("GN Time: %.3f seconds" % (endtime - starttime))
317 return 0 318 return 0
318 319
319 320
320 if __name__ == '__main__': 321 if __name__ == '__main__':
321 sys.exit(main(sys.argv)) 322 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « third_party/tcmalloc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698