Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2405503002: Use FileDescriptorWatcher in AlarmTimer. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
Chirantan Ekbote
CC:
chromium-reviews, chirantan+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in AlarmTimer. This CL is identical to https://codereview.chromium.org/2398753003/ which was reverted % fixes to avoid memory leaks in tests. FileDescriptorWatcher is a new API that replaces MessageLoopForIO::WatchFileDescriptor. This CL also gets rid of the base::Thread created in the anonymous namespace of alarm_timer_chromeos.cc. The FileDescriptorWatcher API is supported by every TaskScheduler thread. Very soon, most tasks in Chrome will run in TaskScheduler. Therefore, there is no reason to create a base::Thread to allow AlarmTimer to be used from threads that don't support the FileDescriptorWatcher API. BUG=645114 Committed: https://crrev.com/51dbb9577b6a8194f025d790f581c10559f3ee2a Cr-Commit-Position: refs/heads/master@{#424471}

Patch Set 1 : identical to https://codereview.chromium.org/2398753003/ #

Patch Set 2 : fix memory leaks #

Patch Set 3 : fix memory leaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -712 lines) Patch
M components/timers/alarm_timer_chromeos.h View 4 chunks +28 lines, -68 lines 0 comments Download
M components/timers/alarm_timer_chromeos.cc View 2 chunks +87 lines, -395 lines 0 comments Download
M components/timers/alarm_timer_unittest.cc View 1 2 6 chunks +192 lines, -249 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-11 12:35:30 UTC) #13
Chirantan Ekbote
lgtm
4 years, 2 months ago (2016-10-11 16:43:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405503002/40001
4 years, 2 months ago (2016-10-11 17:04:43 UTC) #16
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-10-11 17:34:02 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:34:59 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/51dbb9577b6a8194f025d790f581c10559f3ee2a
Cr-Commit-Position: refs/heads/master@{#424471}

Powered by Google App Engine
This is Rietveld 408576698