Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 24055009: Isolate elements are treated as neutral in UBA however Blink UBA implementation iterates over all t… (Closed)

Created:
7 years, 3 months ago by igoroliveira
Modified:
7 years, 3 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, jeez, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Isolate elements are treated as neutral in UBA however Blink UBA implementation iterates over all the isolate characters. The purpose of this patch is reduce the algorithm complexity skipping isolate elements when found in the UBA. Additionaly, rename the pastEnd variable to lastParagraphEnded. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157874

Patch Set 1 #

Patch Set 2 : Proposed patch v2 #

Patch Set 3 : Proposed patch v3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -27 lines) Patch
M Source/core/platform/text/BidiResolver.h View 7 chunks +27 lines, -20 lines 0 comments Download
M Source/core/rendering/InlineIterator.h View 1 2 3 chunks +21 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
igoroliveira
7 years, 3 months ago (2013-09-12 20:44:36 UTC) #1
leviw_travelin_and_unemployed
lgtm
7 years, 3 months ago (2013-09-12 21:04:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/24055009/1
7 years, 3 months ago (2013-09-12 21:04:28 UTC) #3
igoroliveira
Levi, could you take a second look? I did small changes in InlineIterator.h
7 years, 3 months ago (2013-09-12 22:52:08 UTC) #4
igoroliveira
7 years, 3 months ago (2013-09-16 16:41:25 UTC) #5
leviw_travelin_and_unemployed
lgtm, thanks for catching the missing letter ;)
7 years, 3 months ago (2013-09-16 18:12:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/24055009/4001
7 years, 3 months ago (2013-09-16 18:14:34 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=5818
7 years, 3 months ago (2013-09-16 19:21:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/24055009/4001
7 years, 3 months ago (2013-09-16 20:21:53 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 20:26:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/24055009/4001
7 years, 3 months ago (2013-09-16 20:50:29 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=5840
7 years, 3 months ago (2013-09-16 23:18:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/24055009/4001
7 years, 3 months ago (2013-09-16 23:44:29 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 02:09:12 UTC) #14
Message was sent while issue was closed.
Change committed as 157874

Powered by Google App Engine
This is Rietveld 408576698