Clean up session crashed bubble field trial & switches.

Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG=653287
Committed: https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d
Cr-Commit-Position: refs/heads/master@{#423913}

[Alexei Svitkine (slow), 2016-10-07 15:30:13]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 15:30:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-10-07 15:33:12]

Description was changed from

==========
Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG=653287
==========

to

==========
Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG=653287
==========

[Alexei Svitkine (slow), 2016-10-07 15:33:22]

asvitkine@chromium.org changed reviewers:
+ jwd@chromium.org

[commit-bot: I haz the power, 2016-10-07 15:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 15:40:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alexei Svitkine (slow), 2016-10-07 15:46:22]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 15:46:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-10-07 15:46:59]

Patchset #1 (id:1) has been deleted

[jwd, 2016-10-07 16:10:45]

lgtm

[Alexei Svitkine (slow), 2016-10-07 16:24:10]

asvitkine@chromium.org changed reviewers:
+ msw@chromium.org

[Alexei Svitkine (slow), 2016-10-07 16:24:11]

+msw for views/ OWNERS

[msw, 2016-10-07 16:54:29]

lgtm with a few minor/tangential questions.

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:79: bool
IsBubbleUIEnabled() {
q: Should http://crbug.com/653287 also cover the removal of this and the infobar
UI? Otherwise, could you file another bug to track that work? Please add a TODO
here citing the appropriate issue.

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:80: // Function
ChangeMetricsReportingState (called when the user chooses to
q: Should this really prevent using the bubble UI from showing altogether? Could
Chrome OS just show the bubble without the checkbox?

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:160: offer_uma_optin =
!IsMetricsReportingPolicyManaged();
q: just double checking, IsUserModifiable() == !IsManaged()?

[commit-bot: I haz the power, 2016-10-07 17:19:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:19:26]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-10-07 17:33:20]

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/session_crashed_bubble_view.cc (right):

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:79: bool
IsBubbleUIEnabled() {
On 2016/10/07 16:54:29, msw wrote:
> q: Should http://crbug.com/653287 also cover the removal of this and the
infobar
> UI? Otherwise, could you file another bug to track that work? Please add a
TODO
> here citing the appropriate issue.

Done. File http://crbug.com/653966

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:80: // Function
ChangeMetricsReportingState (called when the user chooses to
On 2016/10/07 16:54:29, msw wrote:
> q: Should this really prevent using the bubble UI from showing altogether?
Could
> Chrome OS just show the bubble without the checkbox?

I agree it should be enabled. I don't have cycles for this in the short term
however, so including this in the bug above.

https://codereview.chromium.org/2405493002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/session_crashed_bubble_view.cc:160: offer_uma_optin =
!IsMetricsReportingPolicyManaged();
On 2016/10/07 16:54:29, msw wrote:
> q: just double checking, IsUserModifiable() == !IsManaged()?

Yep, for metrics pref that is the case. Some prefs are connected to specific
command line flags and can be not modifiable due to those, but that is not the
case for metrics reporting pref. Note: We also use the same logic for the
options UI for this pref, so with this change the use of the API is consistent.

[Alexei Svitkine (slow), 2016-10-07 17:33:24]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-10-07 17:33:24]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2405493002/#ps40001
(title: "Add a crbug TODO.")

[commit-bot: I haz the power, 2016-10-07 17:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 18:24:35]

Description was changed from

==========
Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG=653287
==========

to

==========
Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG=653287
==========

[commit-bot: I haz the power, 2016-10-07 18:24:36]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-07 18:27:43]

Description was changed from

==========
Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG=653287
==========

to

==========
Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG=653287

Committed: https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d
Cr-Commit-Position: refs/heads/master@{#423913}
==========

[commit-bot: I haz the power, 2016-10-07 18:27:44]

Patchset 2 (id:??) landed as
https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d
Cr-Commit-Position: refs/heads/master@{#423913}